zhangyiss/FTXUI
1
0
Fork 0
mirror of https://github.com/ArthurSonzogni/FTXUI.git synced 2025-09-18 09:08:08 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Possible clarification and reimplementation of Ref<T> classes (#719)

Browse Source 
Co-authored-by: ArthurSonzogni <sonzogniarthur@gmail.com>
This commit is contained in:
mr-mocap
2023-08-12 15:18:33 -04:00
committed by GitHub
parent 461d557674
commit 06ba1c10b9
3 changed files with 62 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/ftxui/component/input.cpp
View File

@@ -568,7 +568,7 @@ Component Input(InputOption option) {
/// placeholder
/// ```
Component Input(StringRef content, InputOption option) {
option.content = content;
option.content = std::move(content);
return Make<InputBase>(std::move(option));
}
@@ -594,8 +594,8 @@ Component Input(StringRef content, InputOption option) {
/// placeholder
/// ```
Component Input(StringRef content, StringRef placeholder, InputOption option) {
option.content = content;
option.placeholder = placeholder;
option.content = std::move(content);
option.placeholder = std::move(placeholder);
return Make<InputBase>(std::move(option));
}

5
src/ftxui/dom/canvas.cpp
View File

@@ -849,15 +849,14 @@ class CanvasNodeBase : public Node {
Element canvas(ConstRef<Canvas> canvas) {
class Impl : public CanvasNodeBase {
public:
// NOLINTNEXTLINE
explicit Impl(ConstRef<Canvas> canvas) : canvas_(std::move(canvas)) {
explicit Impl(ConstRef<Canvas> canvas) : canvas_(canvas) {
requirement_.min_x = (canvas_->width() + 1) / 2;
requirement_.min_y = (canvas_->height() + 3) / 4;
}
const Canvas& canvas() final { return *canvas_; }
ConstRef<Canvas> canvas_;
};
return std::make_shared<Impl>(std::move(canvas));
return std::make_shared<Impl>(canvas);
}
/// @brief Produce an element drawing a canvas of requested size.