mirror of
https://github.com/ArthurSonzogni/FTXUI.git
synced 2025-09-23 21:58:09 +08:00
terminal_input_parser: validate UTF8.
Make sure code points parsed are always valid UTF8. Don't assume stdin is filled with valid data. Check for overlong UTF8 and add some tests. The fuzzer has reached the following coverage: - cov : 204 - ft : 754 - corp : 62/12257b - lim : 2798 - exec/s : 1748 - rss : 445Mb - L : 155/1946 - MS : 3 Fixed:https://github.com/ArthurSonzogni/FTXUI/issues/118
This commit is contained in:

committed by
Arthur Sonzogni

parent
986ea2b37e
commit
18d1b04b7a
@@ -149,6 +149,88 @@ TEST(Event, MouseRightClick) {
|
||||
EXPECT_FALSE(event_receiver->Receive(&received));
|
||||
}
|
||||
|
||||
TEST(Event, UTF8) {
|
||||
struct {
|
||||
std::vector<unsigned char> input;
|
||||
bool valid;
|
||||
} kTestCase[] = {
|
||||
// Basic characters.
|
||||
{{'a'}, true},
|
||||
{{'z'}, true},
|
||||
{{'A'}, true},
|
||||
{{'Z'}, true},
|
||||
{{'0'}, true},
|
||||
{{'9'}, true},
|
||||
|
||||
// UTF-8 of various size:
|
||||
{{0b0100'0001}, true},
|
||||
{{0b1100'0010, 0b1000'0000}, true},
|
||||
{{0b1110'0010, 0b1000'0000, 0b1000'0000}, true},
|
||||
{{0b1111'0010, 0b1000'0000, 0b1000'0000, 0b1000'0000}, true},
|
||||
|
||||
// Overlong UTF-8 encoding:
|
||||
{{0b1100'0000, 0b1000'0000}, false},
|
||||
{{0b1110'0000, 0b1000'0000, 0b1000'0000}, false},
|
||||
{{0b1111'0000, 0b1000'0000, 0b1000'0000, 0b1000'0000}, false},
|
||||
|
||||
// Test limits in between the various legal regions
|
||||
// https://unicode.org/versions/corrigendum1.html
|
||||
// Limit in between the valid and ina
|
||||
// {{0x7F}, true}, => Special sequence.
|
||||
{{0x80}, false},
|
||||
// ---
|
||||
{{0xC1, 0x80}, false},
|
||||
{{0xC2, 0x7F}, false},
|
||||
{{0xC2, 0x80}, true},
|
||||
// ---
|
||||
{{0xDF, 0xBF}, true},
|
||||
{{0xDF, 0xC0}, false},
|
||||
// ---
|
||||
{{0xE0, 0x9F, 0x80}, false},
|
||||
{{0xE0, 0xA0, 0x7F}, false},
|
||||
{{0xE0, 0xA0, 0x80}, true},
|
||||
// ---
|
||||
{{0xE0, 0xBF, 0xBF}, true},
|
||||
// ---
|
||||
{{0xE1, 0x7F, 0x80}, false},
|
||||
{{0xE1, 0x80, 0x7f}, false},
|
||||
{{0xE1, 0x80, 0x80}, true},
|
||||
// --
|
||||
{{0xEF, 0xBF, 0xBF}, true},
|
||||
{{0xEF, 0xC0, 0xBF}, false},
|
||||
{{0xEF, 0xBF, 0xC0}, false},
|
||||
// --
|
||||
{{0xF0, 0x90, 0x80}, false},
|
||||
{{0xF0, 0x8F, 0x80, 0x80}, false},
|
||||
{{0xF0, 0x90, 0x80, 0x7F}, false},
|
||||
{{0xF0, 0x90, 0x80, 0x80}, true},
|
||||
// --
|
||||
{{0xF1, 0x80, 0x80, 0x80}, true},
|
||||
// --
|
||||
{{0xF1, 0xBF, 0xBF, 0xBF}, true},
|
||||
// --
|
||||
{{0xF2, 0x80, 0x80, 0x80}, true},
|
||||
// --
|
||||
{{0xF4, 0x8F, 0xBF, 0xBF}, true},
|
||||
{{0xF4, 0x90, 0xBF, 0xBF}, false},
|
||||
|
||||
};
|
||||
for (auto test : kTestCase) {
|
||||
auto event_receiver = MakeReceiver<Event>();
|
||||
{
|
||||
auto parser = TerminalInputParser(event_receiver->MakeSender());
|
||||
for (auto input : test.input)
|
||||
parser.Add(input);
|
||||
}
|
||||
Event received;
|
||||
if (test.valid) {
|
||||
EXPECT_TRUE(event_receiver->Receive(&received));
|
||||
EXPECT_TRUE(received.is_character());
|
||||
}
|
||||
EXPECT_FALSE(event_receiver->Receive(&received));
|
||||
}
|
||||
}
|
||||
|
||||
// Copyright 2020 Arthur Sonzogni. All rights reserved.
|
||||
// Use of this source code is governed by the MIT license that can be found in
|
||||
// the LICENSE file.
|
||||
|
Reference in New Issue
Block a user