zhangyiss/FTXUI
1
0
Fork 0
mirror of https://github.com/ArthurSonzogni/FTXUI.git synced 2025-09-18 17:18:08 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove explicit default destructors (#157)

Browse Source 
From CppCoreGuidelines:

Rule of Zero: C.20: If you can avoid defining default operations, do.
C.52: Use inheriting constructors to import constructors into a derived class that does not need further explicit initialization.
DRY forward and using declarations.
Miscellaneous:

Fix format.sh to output examples with normalised paths in sorted order.

Co-authored-by: ArthurSonzogni <sonzogniarthur@gmail.com>
This commit is contained in:
Tushar Maheshwari
2021-07-17 15:32:08 +05:30
committed by GitHub
parent b3a333b417
commit 21d746e858
38 changed files with 67 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/ftxui/component/component.cpp
View File

@@ -14,10 +14,7 @@
namespace ftxui {
namespace {
class CaptureMouseImpl : public CapturedMouseInterface {
public:
~CaptureMouseImpl() override {}
};
class CaptureMouseImpl : public CapturedMouseInterface {};
} // namespace
ComponentBase::~ComponentBase() {
@@ -161,9 +158,9 @@ void ComponentBase::TakeFocus() {
/// @param event
/// @ingroup component
CapturedMouse ComponentBase::CaptureMouse(const Event& event) {
if (!event.screen_)
return std::make_unique<CaptureMouseImpl>();
return event.screen_->CaptureMouse();
if (event.screen_)
return event.screen_->CaptureMouse();
return std::make_unique<CaptureMouseImpl>();
}
} // namespace ftxui