zhangyiss/FTXUI
1
0
Fork 0
mirror of https://github.com/ArthurSonzogni/FTXUI.git synced 2025-09-15 23:48:15 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Implement Fallback for microsoft's terminals. (#138)

Browse Source 
I finally got access to a computer using the Microsoft's Windows OS.
That's the opportunity to find and mitigate all the problems
encountered. This patch:

1. Introduce an option and a C++ definition to enable fallback for
   Microsoft's terminal emulators. This allows me to see/test the
   Microsoft output from Linux. This also allows Windows users to remove
   the fallback and target non Microsoft terminals on Windows if needed.

2. Microsoft's terminal suffer from a race condition bug when reporting
   the cursor position:
   https://github.com/microsoft/terminal/pull/7583.
   The mitigation is not to ask for the cursor position in fullscreen
   mode where it isn't really needed and request it less often.
   This fixes: https://github.com/ArthurSonzogni/FTXUI/issues/136

3. Microsoft's terminal do not handle properly hidding the cursor. Instead
   the character under the cursor is hidden, which is a big problem. As
   a result, we don't enable setting the cursor to the best position for
   [input method editors](https://en.wikipedia.org/wiki/Input_method),
   It will be displayed at the bottom right corner.
   See:
   - https://github.com/microsoft/terminal/issues/1203
   - https://github.com/microsoft/terminal/issues/3093

4. Microsoft's terminals do not provide a way to query if they support
   colors. As a fallback, assume true colors is supported.
   See issue:
   - https://github.com/microsoft/terminal/issues/1040
   This mitigates:
   - https://github.com/ArthurSonzogni/FTXUI/issues/135

5. The "cmd" on Windows do not properly report its dimension. Powershell
   works correctly. As a fallback, use a 80x80 size instead of 0x0.

6. There are several dom elements and component displayed incorrectly,
   because the font used is missing several unicode glyph. Use
   alternatives or less detailled one as a fallback.
This commit is contained in:
Arthur Sonzogni
2021-07-04 17:38:31 +02:00
committed by GitHub
parent bd21cac2b6
commit 81b428af5a
13 changed files with 107 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/ftxui/component/checkbox.hpp
View File

@@ -25,13 +25,8 @@ class CheckboxBase : public ComponentBase {
CheckboxBase(ConstStringRef label, bool* state);
~CheckboxBase() override = default;
#if defined(_WIN32)
std::wstring checked = L"[X] "; /// Prefix for a "checked" state.
std::wstring unchecked = L"[ ] "; /// Prefix for an "unchecked" state.
#else
std::wstring checked = L"▣ "; /// Prefix for a "checked" state.
std::wstring unchecked = L"☐ "; /// Prefix for a "unchecked" state.
#endif
Decorator focused_style = inverted; /// Decorator used when focused.
Decorator unfocused_style = nothing; /// Decorator used when unfocused.

5
include/ftxui/component/radiobox.hpp
View File

@@ -27,13 +27,8 @@ class RadioboxBase : public ComponentBase {
int focused = 0;
#if defined(_WIN32)
std::wstring checked = L"(*) ";
std::wstring unchecked = L"( ) ";
#else
std::wstring checked = L"◉ ";
std::wstring unchecked = L"○ ";
#endif
Decorator focused_style = inverted;
Decorator unfocused_style = nothing;

4
include/ftxui/component/screen_interactive.hpp
View File

@@ -56,8 +56,8 @@ class ScreenInteractive : public Screen {
std::atomic<bool> quit_ = false;
int cursor_x_ = 0;
int cursor_y_ = 0;
int cursor_x_ = 1;
int cursor_y_ = 1;
bool mouse_captured = false;
};