Refactor component containers.

ftxui/CMakeLists.txt

@@ -31,9 +31,7 @@ add_library(dom
 
 add_library(component
   src/ftxui/component/component.cpp
-  src/ftxui/component/component_direction.cpp
-  src/ftxui/component/component_horizontal.cpp
-  src/ftxui/component/component_vertical.cpp
+  src/ftxui/component/container.cpp
   src/ftxui/component/event.cpp
   src/ftxui/component/input.cpp
   src/ftxui/component/menu.cpp

ftxui/include/ftxui/component/component.hpp

@@ -13,50 +13,43 @@ class Focus;
 class Component {
  public:
 
-  class Delegate {
-   public:
-    Delegate() {}
-    virtual ~Delegate() {}
-
-    // A Delegate shadows a component.
-    virtual void Register(Component* component) = 0;
-    virtual Component* component() = 0;
-
-    // Create new children.
-    virtual Delegate* NewChild() = 0;
-    virtual std::vector<Delegate*> children() = 0;
-
-    // Navigate in the tree.
-    virtual Delegate* PreviousSibling() = 0;
-    virtual Delegate* NextSibling() = 0;
-    virtual Delegate* Parent() = 0;
-    virtual Delegate* Root() = 0;
-  };
-
   // Constructor/Destructor.
-  Component(Delegate* delegate);
+  Component() = default;
   virtual ~Component();
 
-  // Render the component.
+  // Component hierarchy.
+  Component* Parent() { return parent_; }
+  void Add(Component* children);
+
+  // Renders the component.
   virtual Element Render();
 
-  // Handle an event. By default, it calls this function on each children.
-  virtual bool OnEvent(Event even);
+  // Handles an event.
+  // By default, reduce on children with a lazy OR.
+  //
+  // Returns whether the event was handled or not.
+  virtual bool OnEvent(Event);
 
-  // If this component contains children, this indicates which one is active. It
-  // can be none of them.
-  // We say an element has the focus if the chain of GetActiveChild() from the
+  // Focus management ----------------------------------------------------------
+  //
+  // If this component contains children, this indicates which one is active,
+  // nullptr if none is active.
+  //
+  // We say an element has the focus if the chain of ActiveChild() from the
   // root component contains this object.
-  virtual Component* GetActiveChild() { return nullptr; }
-  bool Active(); // True is this component is an active child.
-  bool Focused(); // True if all the ancestors are active childs.
+  virtual Component* ActiveChild();
+  // Whether this is the active child of its parent.
+  bool Active();
+  // Whether all the ancestors are active.
+  bool Focused();
 
-  Component* Parent();
-  Component* PreviousSibling();
-  Component* NextSibling();
-  
  private:
-  Delegate* delegate_;
+  Component* parent_ = nullptr;
+  void Detach();
+  void Attach(Component* parent);
+
+ protected:
+  std::vector<Component*> children_;
 };
 
 }  // namespace ftxui

ftxui/include/ftxui/component/component_direction.hpp

@@ -1,24 +0,0 @@
-#ifndef FTXUI_COMPONENT_COMPONENT_DIRECTION_H_
-#define FTXUI_COMPONENT_COMPONENT_DIRECTION_H_
-
-#include "ftxui/component/component.hpp"
-
-namespace ftxui {
-
-// A component where focus and events are automatically handled for you.
-// Please use ComponentVertical or ComponentHorizontal.
-class ComponentDirection : public Component {
- public:
-  ComponentDirection(Delegate* delegate);
-  bool OnEvent(Event) override;
-  Component* GetActiveChild() override;
-
- protected:
-  void Focus(Component* child);
-  virtual bool HandleDirection(Event) = 0;
-  Component* active_child_;
-};
-
-} // namespace ftxui
-
-#endif /* end of include guard: FTXUI_COMPONENT_COMPONENT_DIRECTION_H_ */

ftxui/include/ftxui/component/component_horizontal.hpp

@@ -1,18 +0,0 @@
-#ifndef FTXUI_COMPONENT_COMPONENT_HORIZONTAL_H_
-#define FTXUI_COMPONENT_COMPONENT_HORIZONTAL_H_
-
-#include "ftxui/component/component_direction.hpp"
-
-namespace ftxui {
-
-// A component where focus and events are automatically handled for you.
-// It assumes its children are put in the horizontal direction.
-class ComponentHorizontal : public ComponentDirection {
- public:
-  ComponentHorizontal(Delegate*);
-  bool HandleDirection(Event) override;
-};
-
-} // namespace ftxui
-
-#endif /* end of include guard: FTXUI_COMPONENT_COMPONENT_HORIZONTAL_H_ */

ftxui/include/ftxui/component/component_vertical.hpp

@@ -1,18 +0,0 @@
-#ifndef FTXUI_COMPONENT_COMPONENT_VERTICAL_H_
-#define FTXUI_COMPONENT_COMPONENT_VERTICAL_H_
-
-#include "ftxui/component/component_direction.hpp"
-
-namespace ftxui {
-
-// A component where focus and events are automatically handled for you.
-// It assumes its children are put in the vertical direction.
-class ComponentVertical : public ComponentDirection {
- public:
-  ComponentVertical(Delegate*);
-  bool HandleDirection(Event) override;
-};
-
-} // namespace ftxui
-
-#endif /* end of include guard: FTXUI_COMPONENT_COMPONENT_VERTICAL_H_ */

ftxui/include/ftxui/component/container.hpp

@@ -0,0 +1,36 @@
+#ifndef FTXUI_COMPONENT_CONTAINER_HPP
+#define FTXUI_COMPONENT_CONTAINER_HPP
+
+#include "ftxui/component/component.hpp"
+
+namespace ftxui {
+
+// A component where focus and events are automatically handled for you.
+// List of container:
+//
+// Please use HorizontalContainer or VerticalContainer.
+class Container : public Component {
+ public:
+  static Container Vertical();
+  static Container Horizontal();
+
+  ~Container() override = default;
+
+  // Component override.
+  bool OnEvent(Event event) override;
+  Component* ActiveChild() override;
+ protected:
+  // Handlers
+  using Handler = bool (Container::*)(Event);
+  Handler handler_;
+  bool Vertical(Event event);
+  bool Horizontal(Event event);
+
+  size_t selected_ = 0;
+
+  Container(Handler);
+};
+
+}  // namespace ftxui
+
+#endif /* end of include guard: FTXUI_COMPONENT_CONTAINER_HPP */

ftxui/include/ftxui/component/input.hpp

@@ -9,8 +9,8 @@ namespace ftxui {
 class Input : public Component {
  public:
   // Constructor.
-  Input(Delegate*);
-  ~Input() override;
+  Input() = default;
+  ~Input() override = default;
 
   // State.
   std::wstring content;

ftxui/include/ftxui/component/menu.hpp

@@ -10,7 +10,8 @@ namespace ftxui {
 class Menu : public Component {
  public:
   // Constructor.
-  Menu(Delegate*);
+  Menu() = default;
+  ~Menu() override = default;
 
   // State.
   std::vector<std::wstring> entries = {};

ftxui/include/ftxui/component/screen_interactive.hpp

@@ -1,31 +1,25 @@
 #ifndef FTXUI_COMPONENT_SCREEN_INTERACTIVE_HPP
 #define FTXUI_COMPONENT_SCREEN_INTERACTIVE_HPP
 
-#include "ftxui/component/component.hpp"
 #include "ftxui/screen/screen.hpp"
 #include <functional>
 #include <memory>
 
 namespace ftxui {
+class Component;
 
-
-class ScreenInteractive : public ftxui::Screen {
+class ScreenInteractive : public Screen {
   public:
     static ScreenInteractive FixedSize(size_t dimx, size_t dimy);
     static ScreenInteractive Fullscreen();
     static ScreenInteractive TerminalOutput();
 
     ~ScreenInteractive();
-    void Loop();
+    void Loop(Component*);
     std::function<void()> ExitLoopClosure();
 
-    Component::Delegate* delegate();
-
   private:
-   class Delegate;
-   std::unique_ptr<Delegate> delegate_;
-
-   void PrepareDraw();
+   void Draw(Component* component);
    bool quit_ = false;
 
    enum class Dimension {
@@ -34,7 +28,6 @@ class ScreenInteractive : public ftxui::Screen {
      Fullscreen,
    };
    Dimension dimension_ = Dimension::Fixed;
-
    ScreenInteractive(size_t dimx, size_t dimy, Dimension dimension);
 };
 

ftxui/include/ftxui/component/toggle.hpp

@@ -10,7 +10,7 @@ namespace ftxui {
 class Toggle : public Component {
  public:
   // Constructor.
-  Toggle(Delegate*);
+  ~Toggle() override = default;
 
   // State.
   size_t activated = 0;

ftxui/include/ftxui/dom/elements.hpp

@@ -9,15 +9,13 @@
 namespace ftxui {
 
 using Element = std::unique_ptr<Node>;
+using Elements = std::vector<Element>;
 using Decorator = std::function<Element(Element)>;
-using Child = std::unique_ptr<Node>;
-using Children = std::vector<Child>;
-using Color = ftxui::Color;
 
 // --- Layout ----
-Element vbox(Children);
-Element hbox(Children);
-Element dbox(Children);
+Element vbox(Elements);
+Element hbox(Elements);
+Element dbox(Elements);
 
 // -- Flexibility --
 Element filler();
@@ -29,7 +27,7 @@ Element text(std::wstring text);
 Element separator();
 Element gauge(float ratio);
 Element frame(Element);
-Element window(Child title, Child content);
+Element window(Element title, Element content);
 Element spinner(int charset_index, size_t image_index);
 
 // -- Decorator ---

ftxui/include/ftxui/dom/take_any_args.hpp

@@ -2,7 +2,7 @@
 
 // Turn a set of arguments into a vector.
 template <class... Args>
-Children unpack(Args... args) {
+Elements unpack(Args... args) {
   using T = std::common_type_t<Args...>;
   std::vector<T> vec;
   (vec.push_back(std::forward<Args>(args)), ...);

ftxui/src/ftxui/component/component.cpp

@@ -1,57 +1,53 @@
 #include "ftxui/component/component.hpp"
-#include "ftxui/component/delegate.hpp"
 #include <assert.h>
 
 namespace ftxui {
+void Component::Detach() { if (!parent_) return; auto it = std::find(std::begin(parent_->children_),
+                      std::end(parent_->children_), this);
+  parent_->children_.erase(it);
 
-Component::Component(Delegate* delegate) {
-  delegate_ = delegate;
-  delegate_->Register(this);
 }
 
-Component::~Component() {}
+void Component::Attach(Component* parent) {
+  Detach();
+  parent_ = parent;
+  parent_->children_.push_back(this);
+}
 
-Element Component::Render() {
-  using namespace ftxui;
-  return text(L"Not implemented component");
+void Component::Add(Component* child) {
+  child->Attach(this);
+}
+
+Component::~Component() {
+  Detach();
 }
 
 bool Component::OnEvent(Event event) {
-  return false;
-}
-
-bool Component::Focused() {
-  Delegate* current = delegate_->Root();
-  while (current) {
-    if (current == delegate_)
+  for(Component* child : children_) {
+    if (child->OnEvent(event))
       return true;
-
-    Component* active_child = current->component()->GetActiveChild();
-    current = active_child ? active_child->delegate_ : nullptr;
   }
   return false;
 }
 
-bool Component::Active() {
-  Delegate* parent = delegate_->Parent();
-  return parent && parent->component()->GetActiveChild() == this;
+Component* Component::ActiveChild() {
+  return children_.empty() ? nullptr : children_.front();
 }
 
-Component* Component::PreviousSibling() {
-  Delegate* sibling = delegate_->PreviousSibling();
-  return sibling ? sibling->component() : nullptr;
+Element Component::Render() {
+  return text(L"Not implemented component");
 }
 
-Component* Component::NextSibling() {
-  Delegate* sibling = delegate_->NextSibling();
-  return sibling ? sibling->component() : nullptr;
-}
-
-Component* Component::Parent() {
-  Delegate* parent_delegate = delegate_->Parent();
-  if (!parent_delegate)
-    return nullptr;
-  return parent_delegate->component();
+bool Component::Focused() {
+  Component* current = this;
+  for(;;) {
+    Component* parent = current->parent_;
+    if (!parent)
+      return true;
+    if (parent->ActiveChild() != current)
+      return false;
+    current = parent;
+  }
 }
 
 }  // namespace ftxui

ftxui/src/ftxui/component/component_direction.cpp

@@ -1,30 +0,0 @@
-#include "ftxui/component/component_direction.hpp"
-
-namespace ftxui {
-
-ComponentDirection::ComponentDirection(Delegate* delegate)
-    : Component(delegate), active_child_(nullptr) {}
-
-bool ComponentDirection::OnEvent(Event event) {
-  if (!Focused())
-    return false;
-
-  if (!active_child_)
-    return false;
-
-  if (active_child_->OnEvent(event))
-    return true;
-
-  return HandleDirection(event);
-
-}
-
-Component* ComponentDirection::GetActiveChild() {
-  return active_child_;
-}
-
-void ComponentDirection::Focus(Component* child) {
-  active_child_ = child;
-}
-
-} // namespace ftxui::Component

ftxui/src/ftxui/component/component_horizontal.cpp

@@ -1,30 +0,0 @@
-#include "ftxui/component/component_horizontal.hpp"
-
-namespace ftxui {
-
-ComponentHorizontal::ComponentHorizontal(Delegate* delegate)
-    : ComponentDirection(delegate) {}
-
-bool ComponentHorizontal::HandleDirection(Event event) {
-  // Left pressed ?
-  if (event == Event::ArrowLeft || event == Event::Character('h')) {
-    Component* previous_sibling = active_child_->PreviousSibling();
-    if (previous_sibling) {
-      active_child_ = previous_sibling;
-      return true;
-    }
-  }
-
-  // Left pressed ?
-  if (event == Event::ArrowRight || event == Event::Character('l')) {
-    Component* next_sibling = active_child_->NextSibling();
-    if (next_sibling) {
-      active_child_ = next_sibling;
-      return true;
-    }
-  }
-
-  return false;
-}
-
-}  // namespace ftxui

ftxui/src/ftxui/component/component_vertical.cpp

@@ -1,30 +0,0 @@
-#include "ftxui/component/component_vertical.hpp"
-
-namespace ftxui {
-
-ComponentVertical::ComponentVertical(Delegate* delegate)
-    : ComponentDirection(delegate) {}
-
-bool ComponentVertical::HandleDirection(Event event) {
-  // Up pressed ?
-  if (event == Event::ArrowUp || event == Event::Character('k')) {
-    Component* previous_sibling = active_child_->PreviousSibling();
-    if (previous_sibling) {
-      active_child_ = previous_sibling;
-      return true;
-    }
-  }
-
-  // Down pressed ?
-  if (event == Event::ArrowDown || event == Event::Character('j')) {
-    Component* next_sibling = active_child_->NextSibling();
-    if (next_sibling) {
-      active_child_ = next_sibling;
-      return true;
-    }
-  }
-
-  return false;
-}
-
-}  // namespace ftxui

ftxui/src/ftxui/component/container.cpp

@@ -0,0 +1,73 @@
+#include "ftxui/component/container.hpp"
+
+namespace ftxui {
+
+// static
+Container Container::Horizontal() {
+  return Container(&Container::Horizontal);
+}
+
+// static
+Container Container::Vertical() {
+  return Container(&Container::Vertical);
+}
+
+Container::Container(Container::Handler handler) : handler_(handler) {}
+
+bool Container::OnEvent(Event event) {
+  if (!Focused())
+    return false;
+
+  if (ActiveChild()->OnEvent(event))
+    return true;
+
+  return (this->*handler_)(event);
+}
+
+Component* Container::ActiveChild() {
+  return children_[selected_ % children_.size()];
+}
+
+bool Container::Vertical(Event event) {
+  selected_ %= children_.size();
+  // Left pressed ?
+  if (event == Event::ArrowUp || event == Event::Character('k')) {
+    if (selected_ != 0) {
+      selected_--;
+      return true;
+    }
+  }
+
+  // Left pressed ?
+  if (event == Event::ArrowDown || event == Event::Character('j')) {
+    if (selected_ != children_.size() - 1) {
+      selected_++;
+      return true;
+    }
+  }
+
+  return false;
+}
+
+bool Container::Horizontal(Event event) {
+  selected_ %= children_.size();
+  // Left pressed ?
+  if (event == Event::ArrowLeft || event == Event::Character('h')) {
+    if (selected_ != 0) {
+      selected_--;
+      return true;
+    }
+  }
+
+  // Left pressed ?
+  if (event == Event::ArrowRight || event == Event::Character('l')) {
+    if (selected_ != children_.size() - 1) {
+      selected_++;
+      return true;
+    }
+  }
+
+  return false;
+}
+
+}  // namespace ftxui

ftxui/src/ftxui/component/input.cpp

@@ -1,11 +1,8 @@
 #include "ftxui/component/input.hpp"
-#include "ftxui/util/string.hpp"
+#include "ftxui/screen/string.hpp"
 
 namespace ftxui {
 
-Input::Input(Delegate* delegate): Component(delegate) {}
-Input::~Input() {}
-
 // Component implementation.
 Element Input::Render() {
   bool is_focused = Focused();

ftxui/src/ftxui/component/menu.cpp

@@ -4,8 +4,6 @@
 
 namespace ftxui {
 
-Menu::Menu(Delegate* delegate) : Component(delegate) {}
-
 Element Menu::Render() {
   std::vector<Element> elements;
   bool focused = Focused();

ftxui/src/ftxui/component/screen_interactive.cpp

@@ -45,53 +45,10 @@ Event GetEvent() {
 
 };  // namespace
 
-class ScreenInteractive::Delegate : public Component::Delegate {
- public:
-  Delegate() : root_(this) {}
-
-  void Register(Component* c) override { component_ = c; }
-
-  std::vector<std::unique_ptr<Delegate>> child_;
-  Delegate* NewChild() override {
-    Delegate* child = new Delegate;
-    child->root_ = root_;
-    child->parent_ = this;
-
-    if (!child_.empty()) {
-      child_.back()->next_sibling_ = child;
-      child->previous_sibling_ = child_.back().get();
-    }
-
-    child_.emplace_back(child);
-    return child;
-  }
-
-  void OnEvent(Event event) { component_->OnEvent(event); }
-
-  std::vector<Component::Delegate*> children() override {
-    std::vector<Component::Delegate*> ret;
-    for (auto& it : child_)
-      ret.push_back(it.get());
-    return ret;
-  }
-
-  Component::Delegate* root_;
-  Component::Delegate* parent_ = nullptr;
-  Component::Delegate* previous_sibling_ = nullptr;
-  Component::Delegate* next_sibling_ = nullptr;
-  Component* component_;
-
-  Component::Delegate* Root() override { return root_; }
-  Component::Delegate* Parent() override { return parent_; }
-  Component::Delegate* PreviousSibling() override { return previous_sibling_; }
-  Component::Delegate* NextSibling() override { return next_sibling_; }
-  Component* component() override { return component_; }
-};
-
 ScreenInteractive::ScreenInteractive(size_t dimx,
                                      size_t dimy,
                                      Dimension dimension)
-    : Screen(dimx, dimy), delegate_(new Delegate), dimension_(dimension) {}
+    : Screen(dimx, dimy), dimension_(dimension) {}
 ScreenInteractive::~ScreenInteractive() {}
 
 // static
@@ -109,10 +66,10 @@ ScreenInteractive ScreenInteractive::TerminalOutput() {
   return ScreenInteractive(0, 0, Dimension::TerminalOutput);
 }
 
-void ScreenInteractive::Loop() {
-  std::cout << "\033[?9h";    /* Send Mouse Row & Column on Button Press */
-  std::cout << "\033[?1000h"; /* Send Mouse X & Y on button press and release */
-  std::cout << std::flush;
+void ScreenInteractive::Loop(Component* component) {
+  //std::cout << "\033[?9h";    [> Send Mouse Row & Column on Button Press <]
+  //std::cout << "\033[?1000h"; [> Send Mouse X & Y on button press and release <]
+  //std::cout << std::flush;
 
   // Save the old terminal configuration.
   struct termios terminal_configuration_old;
@@ -130,23 +87,27 @@ void ScreenInteractive::Loop() {
 
   std::string reset_position;
   while (!quit_) {
-    PrepareDraw();
+    Draw(component);
     std::cout << reset_position << ToString() << std::flush;
     reset_position = ResetPosition();
     Clear();
-    delegate_->OnEvent(GetEvent());
+    component->OnEvent(GetEvent());
   }
 
   // Restore the old terminal configuration.
   tcsetattr(STDIN_FILENO, TCSANOW, &terminal_configuration_old);
+
+  std::cout << std::endl;
 }
 
-void ScreenInteractive::PrepareDraw() {
-  auto document = delegate_->component()->Render();
+void ScreenInteractive::Draw(Component* component) {
+  auto document = component->Render();
   size_t dimx;
   size_t dimy;
   switch (dimension_) {
     case Dimension::Fixed:
+      dimx = dimx_;
+      dimy = dimy_;
       break;
     case Dimension::TerminalOutput:
       document->ComputeRequirement();
@@ -161,8 +122,10 @@ void ScreenInteractive::PrepareDraw() {
   }
 
   if (dimx != dimx_ || dimy != dimy_) {
+    std::cerr << dimx_ << " " << dimy_ << std::endl;
     dimx_ = dimx;
     dimy_ = dimy;
+    std::cerr << dimx_ << " " << dimy_ << std::endl;
     pixels_ = std::vector<std::vector<Pixel>>(
         dimy, std::vector<Pixel>(dimx));
   }
@@ -170,10 +133,6 @@ void ScreenInteractive::PrepareDraw() {
   Render(*this, document.get());
 }
 
-Component::Delegate* ScreenInteractive::delegate() {
-  return delegate_.get();
-}
-
 std::function<void()> ScreenInteractive::ExitLoopClosure() {
   return [this]() { quit_ = true; };
 }

ftxui/src/ftxui/component/toggle.cpp

@@ -2,13 +2,10 @@
 
 namespace ftxui {
 
-Toggle::Toggle(Delegate* delegate) : Component(delegate) {}
-
 Element Toggle::Render() {
   auto highlight = Focused() ? inverted : bold;
 
-  Children children;
-
+  Elements children;
   for(size_t i = 0; i<options.size(); ++i) {
     // Separator.
     if (i != 0)

ftxui/src/ftxui/dom/blink.cpp

@@ -5,7 +5,7 @@ namespace ftxui {
 
 class Blink : public NodeDecorator {
  public:
-  Blink(Children children) : NodeDecorator(std::move(children)) {}
+  Blink(Elements children) : NodeDecorator(std::move(children)) {}
   ~Blink() override {}
 
   void Render(Screen& screen) override {
@@ -18,7 +18,7 @@ class Blink : public NodeDecorator {
   }
 };
 
-std::unique_ptr<Node> blink(Child child) {
+std::unique_ptr<Node> blink(Element child) {
   return std::make_unique<Blink>(unpack(std::move(child)));
 }
 

ftxui/src/ftxui/dom/bold.cpp

@@ -5,7 +5,7 @@ namespace ftxui {
 
 class Bold : public NodeDecorator {
  public:
-  Bold(Children children) : NodeDecorator(std::move(children)) {}
+  Bold(Elements children) : NodeDecorator(std::move(children)) {}
   ~Bold() override {}
 
   void Render(Screen& screen) override {
@@ -18,7 +18,7 @@ class Bold : public NodeDecorator {
   }
 };
 
-std::unique_ptr<Node> bold(Child child) {
+std::unique_ptr<Node> bold(Element child) {
   return std::make_unique<Bold>(unpack(std::move(child)));
 }
 

ftxui/src/ftxui/dom/color.cpp

@@ -5,7 +5,7 @@ namespace ftxui {
 
 class BgColor : public NodeDecorator {
  public:
-  BgColor(Children children, Color color)
+  BgColor(Elements children, Color color)
       : NodeDecorator(std::move(children)), color_(color) {}
 
   void Render(Screen& screen) override {
@@ -22,7 +22,7 @@ class BgColor : public NodeDecorator {
 
 class FgColor : public NodeDecorator {
  public:
-  FgColor(Children children, Color color)
+  FgColor(Elements children, Color color)
       : NodeDecorator(std::move(children)), color_(color) {}
   ~FgColor() override {}
 
@@ -38,22 +38,22 @@ class FgColor : public NodeDecorator {
   Color color_;
 };
 
-std::unique_ptr<Node> color(Color c, Child child) {
+std::unique_ptr<Node> color(Color c, Element child) {
   return std::make_unique<FgColor>(unpack(std::move(child)), c);
 }
 
-std::unique_ptr<Node> bgcolor(Color c, Child child) {
+std::unique_ptr<Node> bgcolor(Color c, Element child) {
   return std::make_unique<BgColor>(unpack(std::move(child)), c);
 }
 
 Decorator color(Color c) {
-  return [c](Child child) {
+  return [c](Element child) {
     return color(c, std::move(child));
   };
 }
 
 Decorator bgcolor(Color c) {
-  return [c](Child child) {
+  return [c](Element child) {
     return bgcolor(c, std::move(child));
   };
 }

ftxui/src/ftxui/dom/dbox.cpp

@@ -5,7 +5,7 @@ namespace ftxui {
 
 class DBox : public Node {
  public:
-  DBox(Children children) : Node(std::move(children)) {}
+  DBox(Elements children) : Node(std::move(children)) {}
   ~DBox() {}
 
   void ComputeRequirement() override {
@@ -28,7 +28,7 @@ class DBox : public Node {
   }
 };
 
-std::unique_ptr<Node> dbox(Children children) {
+std::unique_ptr<Node> dbox(Elements children) {
   return std::make_unique<DBox>(std::move(children));
 }
 

ftxui/src/ftxui/dom/dim.cpp

@@ -7,7 +7,7 @@ using ftxui::Screen;
 
 class Dim : public NodeDecorator {
  public:
-  Dim(Children children) : NodeDecorator(std::move(children)) {}
+  Dim(Elements children) : NodeDecorator(std::move(children)) {}
   ~Dim() override {}
 
   void Render(Screen& screen) override {
@@ -20,7 +20,7 @@ class Dim : public NodeDecorator {
   }
 };
 
-std::unique_ptr<Node> dim(Child child) {
+std::unique_ptr<Node> dim(Element child) {
   return std::make_unique<Dim>(unpack(std::move(child)));
 }
 

ftxui/src/ftxui/dom/frame.cpp

@@ -9,7 +9,7 @@ static wchar_t charset[] = L"┌┐└┘─│┬┴┤├";
 
 class Frame : public Node {
  public:
-  Frame(Children children) : Node(std::move(children)) {}
+  Frame(Elements children) : Node(std::move(children)) {}
   ~Frame() override {}
 
   void ComputeRequirement() override {
@@ -81,16 +81,16 @@ class Frame : public Node {
   }
 };
 
-std::unique_ptr<Node> frame(Child child) {
+std::unique_ptr<Node> frame(Element child) {
   return std::make_unique<Frame>(unpack(std::move(child)));
 }
 
-std::unique_ptr<Node> window(Child title, Child content) {
+std::unique_ptr<Node> window(Element title, Element content) {
   return std::make_unique<Frame>(unpack(std::move(content), std::move(title)));
 }
 
 Decorator boxed() {
-  return [](Child child) {
+  return [](Element child) {
     return frame(std::move(child));
   };
 }

ftxui/src/ftxui/dom/hbox.cpp

@@ -5,7 +5,7 @@ namespace ftxui {
 
 class HBox : public Node {
  public:
-  HBox(Children children) : Node(std::move(children)) {}
+  HBox(Elements children) : Node(std::move(children)) {}
   ~HBox() {}
 
   void ComputeRequirement() override {
@@ -59,7 +59,7 @@ class HBox : public Node {
   }
 };
 
-std::unique_ptr<Node> hbox(Children children) {
+std::unique_ptr<Node> hbox(Elements children) {
   return std::make_unique<HBox>(std::move(children));
 }
 

ftxui/src/ftxui/dom/inverted.cpp

@@ -7,7 +7,7 @@ using ftxui::Screen;
 
 class Inverted : public NodeDecorator {
  public:
-  Inverted(Children children) : NodeDecorator(std::move(children)) {}
+  Inverted(Elements children) : NodeDecorator(std::move(children)) {}
   ~Inverted() override {}
 
   void Render(Screen& screen) override {
@@ -20,7 +20,7 @@ class Inverted : public NodeDecorator {
   }
 };
 
-std::unique_ptr<Node> inverted(Child child) {
+std::unique_ptr<Node> inverted(Element child) {
   return std::make_unique<Inverted>(unpack(std::move(child)));
 }
 

ftxui/src/ftxui/dom/node_decorator.hpp

@@ -9,7 +9,7 @@ namespace ftxui {
 // Helper class.
 class NodeDecorator : public Node {
  public:
-  NodeDecorator(Children children) : Node(std::move(children)) {}
+  NodeDecorator(Elements children) : Node(std::move(children)) {}
   ~NodeDecorator() override {}
   void ComputeRequirement() override;
   void SetBox(Box box) override;

ftxui/src/ftxui/dom/underlined.cpp

@@ -7,7 +7,7 @@ using ftxui::Screen;
 
 class Underlined : public NodeDecorator {
  public:
-  Underlined(Children children) : NodeDecorator(std::move(children)) {}
+  Underlined(Elements children) : NodeDecorator(std::move(children)) {}
   ~Underlined() override {}
 
   void Render(Screen& screen) override {
@@ -20,7 +20,7 @@ class Underlined : public NodeDecorator {
   }
 };
 
-std::unique_ptr<Node> underlined(Child child) {
+std::unique_ptr<Node> underlined(Element child) {
   return std::make_unique<Underlined>(unpack(std::move(child)));
 }
 

ftxui/src/ftxui/dom/vbox.cpp

@@ -5,7 +5,7 @@ namespace ftxui {
 
 class VBox : public Node {
  public:
-  VBox(Children children) : Node(std::move(children)) {}
+  VBox(Elements children) : Node(std::move(children)) {}
   ~VBox() {}
 
   void ComputeRequirement() {
@@ -59,7 +59,7 @@ class VBox : public Node {
   }
 };
 
-std::unique_ptr<Node> vbox(Children children) {
+std::unique_ptr<Node> vbox(Elements children) {
   return std::make_unique<VBox>(std::move(children));
 }