zhangyiss/editline
1
0
Fork 0
mirror of https://github.com/troglobit/editline.git synced 2025-10-31 16:28:15 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix suspicious use of sizeof(char **), same as sizeof(char *) but not portable.

Browse Source 
Coverity CID #56740, #56741, #56742

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
This commit is contained in:
Joachim Nilsson
2014-11-04 23:42:37 +01:00
parent e53ccf61f2
commit 394c4f82a9
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/complete.c
View File

@@ -75,7 +75,7 @@ static int FindMatches(char *dir, char *file, char ***avp)
break;
}
if (ac) {
memcpy(word, av, ac * sizeof(char **));
memcpy(word, av, ac * sizeof(char *));
free(av);
}
*avp = av = word;
@@ -105,7 +105,7 @@ static int FindMatches(char *dir, char *file, char ***avp)
if ((p = strdup("choices")) != NULL) av[ac++] = p;
} else {
if (ac)
qsort(av, ac, sizeof (char **), compare);
qsort(av, ac, sizeof(char *), compare);
}
return ac;

2
src/editline.c
View File

@@ -1576,7 +1576,7 @@ static int argify(char *line, char ***avp)
return ac;
}
memcpy(arg, p, i * sizeof(char **));
memcpy(arg, p, i * sizeof(char *));
i += MEM_INC;
free(p);
*avp = p = arg;