zhangyiss/editline
1
0
Fork 0
mirror of https://github.com/troglobit/editline.git synced 2025-11-01 01:01:34 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix out-of-bounds access in user key binding routines.

Browse Source 
Coverity CID #56737, #56738

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
This commit is contained in:
Joachim Nilsson
2014-11-04 23:50:45 +01:00
parent 394c4f82a9
commit 8fbc87707e
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/editline.c
View File

@@ -1683,7 +1683,7 @@ static size_t find_key_in_map(int key, el_keymap_t map[], size_t mapsz)
{ {
size_t i; size_t i;
for (i = 0; map[i].Function != NULL; i++) { for (i = 0; map[i].Function; i++) {
if (map[i].Key == key) if (map[i].Key == key)
return i; return i;
} }
@@ -1705,7 +1705,9 @@ static el_status_t el_bind_key_in_map(int key, el_keymap_func_t function, el_key
{ {
size_t creat, pos = find_key_in_map(key, map, mapsz); size_t creat, pos = find_key_in_map(key, map, mapsz);
if (pos == mapsz) { /* Must check that pos is not the next to last array position,
* otherwise we will write out-of-bounds to terminate the list. */
if (pos >= mapsz - 1) {
errno = ENOMEM; errno = ENOMEM;
return CSeof; return CSeof;
} }