From ea79fe70f9c9ff725bbb69e1974640f72ec74899 Mon Sep 17 00:00:00 2001 From: Joachim Nilsson Date: Wed, 29 Nov 2017 21:40:38 +0100 Subject: [PATCH] write_history(), read_history(): Check fclose() return value Signed-off-by: Joachim Nilsson --- src/editline.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/editline.c b/src/editline.c index 895727e..02517fe 100644 --- a/src/editline.c +++ b/src/editline.c @@ -1070,7 +1070,8 @@ static void hist_add(const char *p) return; #endif - if ((s = strdup(p)) == NULL) + s = strdup(p); + if (s == NULL) return; if (H.Size < el_hist_size) { @@ -1337,9 +1338,8 @@ int read_history(const char *filename) buf[strlen(buf) - 1] = 0; /* Remove '\n' */ add_history(buf); } - fclose(fp); - return 0; + return fclose(fp); } return errno; @@ -1357,9 +1357,7 @@ int write_history(const char *filename) while (i < H.Size) fprintf(fp, "%s\n", H.Lines[i++]); - fclose(fp); - - return 0; + return fclose(fp); } return errno;