Small packaging tweaks:

These were suggested by paultag@debian.org

1. debian/changelog just has the one entry, to indicate what has changed from
the perspective of a user of this package. The old changes in that file have
never been uploaded to Debian

2. Uploading to unstable instead of experimental

3. Bumped up debhelper compat to 9

4. Removed DM-Upload-Allowed

5. Minor standards bump

Changes

@@ -1,3 +1,11 @@
+feedgnuplot (1.23)
+
+  * --extracmds no longer accepts comma-separated lists
+    This was needed because a command can have a comma
+  * --curvestyle no longer adds on top of --curvestyleall
+
+ -- Dima Kogan <dima@secretsauce.net>  Sat, 29 Sep 2012 16:29:38 -0700
+
 feedgnuplot (1.22)
 
   * removed --size option

bin/feedgnuplot

@@ -95,8 +95,9 @@ sub interpretCommandline
 
   # Previously I was using 'legend=s%' and 'curvestyle=s%' for curve addressing. This had cleaner
   # syntax, but disregarded the order of the given options. This resulted in arbitrarily ordered
-  # curves.
+  # curves. I thus make parse these into lists, and then also make hashes, for later use
-  # needed for these to be parsed into a ref to a list
+
+  # needed for these to be parsed into an array-ref
   $options{legend}     = [];
   $options{curvestyle} = [];
   $options{histogram}  = [];
@@ -118,12 +119,27 @@ sub interpretCommandline
   $options->{curvestyleall} = '' unless defined $options->{curvestyleall};
 
   # expand options that are given as comma-separated lists
-  for my $listkey (qw(extracmds histogram y2))
+  for my $listkey (qw(histogram y2))
   {
     @{$options{$listkey}} = map split('\s*,\s*', $_), @{$options{$listkey}}
       if defined $options{$listkey};
   }
 
+  # --legend and --curvestyle options are conceptually hashes, but are parsed as
+  # arrays in order to preserve the ordering. I parse both of these into hashes
+  # because those are useful to have later. After this I can access individual
+  # legends with $options{legend_hash}{curveid}
+  for my $listkey (qw(legend curvestyle))
+  {
+    $options{"${listkey}_hash"} = {};
+
+    my $n = scalar @{$options{$listkey}}/2;
+    foreach my $idx (0..$n-1)
+    {
+      $options{"${listkey}_hash"}{$options{$listkey}[$idx*2]} = $options{$listkey}[$idx*2 + 1];
+    }
+  }
+
   # parse stream option. Allowed only numbers >= 0 or 'trigger'
   if(defined $options->{stream})
   {
@@ -376,7 +392,10 @@ sub mainThread
 # For the specified values, set the legend entries to 'title "blah blah"'
     if(@{$options{legend}})
     {
-      # @{$options{legend}} is a list where consecutive pairs are (curveID, legend)
+      # @{$options{legend}} is a list where consecutive pairs are (curveID,
+      # legend). I use $options{legend} here instead of $options{legend_hash}
+      # because I create a new curve when I see a new one, and the hash is
+      # unordered, thus messing up the ordering
       my $n = scalar @{$options{legend}}/2;
       foreach my $idx (0..$n-1)
       {
@@ -388,7 +407,10 @@ sub mainThread
 # add the extra curve options
     if(@{$options{curvestyle}})
     {
-      # @{$options{curvestyle}} is a list where consecutive pairs are (curveID, style)
+      # @{$options{curvestyle}} is a list where consecutive pairs are (curveID,
+      # style). I use $options{curvestyle} here instead of
+      # $options{curvestyle_hash} because I create a new curve when I see a new
+      # one, and the hash is unordered, thus messing up the ordering
       my $n = scalar @{$options{curvestyle}}/2;
       foreach my $idx (0..$n-1)
       {
@@ -598,10 +620,14 @@ sub updateCurveOptions
   { $title = $id; }
 
   my $titleoption = defined $title ? "title \"$title\"" : "notitle";
-  my $extraoption = defined $options{curvestyleall} ? $options{curvestyleall} : '';
+
+  my $curvestyleall = '';
+  $curvestyleall = $options{curvestyleall}
+    if defined $options{curvestyleall} && !defined $options{curvestyle_hash}{$id};
+
   my $histoptions = $curveoptions->{histoptions} || '';
 
-  $curveoptions->{options} = "$histoptions $titleoption $curveoptions->{extraoptions} $extraoption";
+  $curveoptions->{options} = "$histoptions $titleoption $curveoptions->{extraoptions} $curvestyleall";
 }
 
 sub getCurve

bin/feedgnuplot.pod

@@ -46,7 +46,8 @@ passed in with C<--extracmds>. For example, to turn off the grid, pass in
 C<--extracmds 'unset grid'>. As many of these options as needed can be passed
 in. To add arbitrary curve styles, use C<--curvestyle curveID extrastyle>. Pass
 these more than once to affect more than one curve. To apply an extra style to
-I<all> the curves, pass in C<--curvestyleall extrastyle>.
+I<all> the curves that lack an explicit C<--curvestyle>, pass in
+C<--curvestyleall extrastyle>.
 
 =head2 Data formats
 
@@ -319,15 +320,16 @@ As an example, if line 3 of the input is "0 9 1 20"
                        'cumulative', but rescaled to end up at 1.0.
 
   --curvestyle curveID style
-                       Additional styles per curve. With --dataid, curveID is the
+                       Additional styles per curve. With --dataid, curveID is
-                       ID. Otherwise, it's the index of the curve, starting at 0. Use
+                       the ID. Otherwise, it's the index of the curve, starting
-                       this option multiple times for multiple curves
+                       at 0. Use this option multiple times for multiple curves.
+                       --curvestylall does NOT apply to curves that have a
+                       --curvestyle
 
-  --curvestyleall xxx  Additional styles for ALL curves.
+  --curvestyleall xxx  Additional styles for all curves that have no --curvestyle
 
   --extracmds xxx      Additional commands. These could contain extra global styles
-                       for instance. Can be passed multiple times, or passed a comma-
+                       for instance. Can be passed multiple times.
-                       separated list
 
   --square             Plot data with aspect ratio 1. For 3D plots, this controls the
                        aspect ratio for all 3 axes

debian/changelog

@@ -1,125 +1,5 @@
-feedgnuplot (1.22-2) experimental; urgency=low
+feedgnuplot (1.23-2) unstable; urgency=low
 
-  * added Anton Gladky as an Uploader
+  * Initial Debian release (Closes: #686413)
-  * added doc-base definition
 
- -- Dima Kogan <dima@secretsauce.net>  Fri, 14 Sep 2012 01:31:34 -0700
+ -- Dima Kogan <dima@secretsauce.net>  Tue, 30 Oct 2012 11:14:01 -0700
-
-feedgnuplot (1.22-1) experimental; urgency=low
-
-  * debianization split from the upstream source
-  * package now uploaded to Debian (Closes: #686413)
-
- -- Dima Kogan <dima@secretsauce.net>  Tue, 11 Sep 2012 11:32:30 -0700
-
-feedgnuplot (1.22) unstable; urgency=low
-
-  * removed --size option
-
- -- Dima Kogan <dima@secretsauce.net>  Mon, 03 Sep 2012 08:33:26 -0700
-
-feedgnuplot (1.21) unstable; urgency=low
-
-  * removed the POD from the script to its own file
-  * fixed regression to allow no given extracmds, histogram or y2
-    options
-
- -- Dima Kogan <dima@secretsauce.net>  Sun, 02 Sep 2012 23:52:21 -0700
-
-feedgnuplot (1.20) unstable; urgency=low
-
-  * no longer hardcoding 'x11' as the default terminal
-  * added histogram support
-  * generic terminals can now be requested
-  * --extracmds, --histogram, --y2 can now take comma-separated lists
-
- -- Dima Kogan <dima@secretsauce.net>  Fri, 31 Aug 2012 01:35:50 -0700
-
-feedgnuplot (1.19) unstable; urgency=low
-
-  * added --geometry option to specify plot dimensions
-
- -- Dima Kogan <dima@secretsauce.net>  Sat, 11 Feb 2012 21:04:42 -0800
-
-feedgnuplot (1.18) unstable; urgency=low
-
-  * data-ids can now include characters such as -. Any non-whitespace
-    works
-
- -- Dima Kogan <dima@secretsauce.net>  Tue, 27 Dec 2011 16:47:36 -0800
-
-feedgnuplot (1.17) unstable; urgency=low
-
-  [ Dima Kogan ]
-  * POD: removed -Winteractive, since this was apparently a mawk-ism
-  * added zsh and bash completions to the package
-
-  [ Hermann Schwarting ]
-  * add build dependency libtest-script-run-perl
-
- -- Dima Kogan <dima@secretsauce.net>  Sun, 20 Nov 2011 19:17:22 -0800
-
-feedgnuplot (1.16) unstable; urgency=low
-
-  * deb version parser now works for any package name
-  * Some POD fixes
-  * now building a native package
-
- -- Dima Kogan <dima@secretsauce.net>  Fri, 11 Nov 2011 00:10:18 -0800
-
-feedgnuplot (1.15-2) unstable; urgency=low
-
-  * added source format for the debianization
-  * added configuration to let git-buildpackage build this package
-  * standards bump to make lintian happier
-
- -- Dima Kogan <dima@secretsauce.net>  Sun, 23 Oct 2011 13:38:15 -0700
-
-feedgnuplot (1.15-1) unstable; urgency=low
-
-  * Renamed main script from feedGnuplot to feedgnuplot
-  * Slightly improved packaging, added instructions, etc
-
- -- Dima Kogan <dima@secretsauce.net>  Sun, 16 Oct 2011 11:58:15 -0700
-
-feedgnuplot (1.14-1) unstable; urgency=low
-
-  * New upstream release (added 'clear' command, documented commands)
-
- -- Dima Kogan <dima@secretsauce.net>  Sun, 22 May 2011 15:25:28 -0700
-
-feedgnuplot (1.13-1) unstable; urgency=low
-
-  * New upstream release (Better streaming plot control)
-
- -- Dima Kogan <dima@secretsauce.net>  Tue, 26 Apr 2011 14:24:09 -0700
-
-feedgnuplot (1.12-1) unstable; urgency=low
-
-  * New upstream release
-
- -- Dima Kogan <dima@secretsauce.net>  Tue, 19 Apr 2011 11:02:23 -0700
-
-feedgnuplot (1.11-1) unstable; urgency=low
-
-  * New upstream release
-
- -- Dima Kogan <dima@secretsauce.net>  Sat, 09 Apr 2011 14:10:21 -0700
-
-feedgnuplot (1.10-1) unstable; urgency=low
-
-  * New upstream release
-
- -- Dima Kogan <dima@secretsauce.net>  Sat, 09 Apr 2011 14:08:06 -0700
-
-feedgnuplot (1.09-1) unstable; urgency=low
-
-  * New upstream release
-
- -- Dima Kogan <dima@secretsauce.net>  Sun, 03 Apr 2011 17:23:38 -0700
-
-feedgnuplot (1.08-1) unstable; urgency=low
-
-  * Initial debianized release.
-
- -- Dima Kogan <dima@secretsauce.net>  Sun, 6 Feb 2011 15:58:22 -0800

debian/compat

@@ -1 +1 @@
-7
+9

debian/control

@@ -1,14 +1,13 @@
 Source: feedgnuplot
 Section: science
 Priority: extra
-Build-Depends: debhelper (>= 7.0.50~), libtest-script-run-perl, perl
+Build-Depends: debhelper (>= 9), libtest-script-run-perl, perl
 Maintainer: Debian Science Maintainers <debian-science-maintainers@lists.alioth.debian.org>
 Uploaders: Dima Kogan <dima@secretsauce.net>, Anton Gladky <gladky.anton@gmail.com>
-Standards-Version: 3.9.3
+Standards-Version: 3.9.4
 Homepage: https://github.com/dkogan/feedgnuplot
 Vcs-Git: git://git.debian.org/git/debian-science/packages/feedgnuplot.git
 Vcs-Browser: http://git.debian.org/?p=debian-science/packages/feedgnuplot.git
-DM-Upload-Allowed: yes
 
 Package: feedgnuplot
 Architecture: all

debian/gbp.conf

@@ -2,6 +2,7 @@
 debian-branch = debian
 upstream-tree = tag
 debian-tag = debian/%(version)s
+upstream-tag = v%(version)s
 pristine-tar = False
 sign-tags = True
 sign-changelog = True

package_definitions/debian/changelog

@@ -1,10 +1,3 @@
-feedgnuplot (1.23) unstable; urgency=low
-
-  * debian packaging cleanup
-  * package now uploaded to Debian (Closes: #686413)
-
- -- Dima Kogan <dima@secretsauce.net>  Mon, 10 Sep 2012 20:47:40 -0700
-
 feedgnuplot (1.22) unstable; urgency=low
 
   * removed --size option