Added terminal size checks in indeterminate progress bar

This commit is contained in:
Pranav Srinivas Kumar
2020-05-25 09:35:29 -05:00
parent 0973cde3d3
commit 6be9c8005f
2 changed files with 44 additions and 6 deletions

View File

@@ -180,8 +180,9 @@ public:
: os(os), bar_width(bar_width), fill(fill), lead(lead) {} : os(os), bar_width(bar_width), fill(fill), lead(lead) {}
std::ostream &write(size_t progress) { std::ostream &write(size_t progress) {
for (size_t i = 0, current_display_width = 0; i < bar_width;) { for (size_t i = 0; i < bar_width;) {
std::string next; std::string next;
size_t current_display_width = 0;
if (i < progress) { if (i < progress) {
next = fill; next = fill;

View File

@@ -9,6 +9,7 @@
#include <cmath> #include <cmath>
#include <indicators/color.hpp> #include <indicators/color.hpp>
#include <indicators/setting.hpp> #include <indicators/setting.hpp>
#include <indicators/terminal_size.hpp>
#include <iomanip> #include <iomanip>
#include <iostream> #include <iostream>
#include <mutex> #include <mutex>
@@ -16,6 +17,8 @@
#include <thread> #include <thread>
#include <tuple> #include <tuple>
#include <type_traits> #include <type_traits>
#include <sstream>
#include <utility>
namespace indicators { namespace indicators {
@@ -156,6 +159,23 @@ private:
template <typename Indicator> friend class DynamicProgress; template <typename Indicator> friend class DynamicProgress;
std::atomic<bool> multi_progress_mode_{false}; std::atomic<bool> multi_progress_mode_{false};
std::pair<std::string, size_t> get_prefix_text() {
std::stringstream os;
os << get_value<details::ProgressBarOption::prefix_text>();
const auto result = os.str();
const auto result_size = result.size();
return {result, result_size};
}
std::pair<std::string, size_t> get_postfix_text() {
std::stringstream os;
os << " " << get_value<details::ProgressBarOption::postfix_text>();
const auto result = os.str();
const auto result_size = result.size();
return {result, result_size};
}
public: public:
void print_progress(bool from_multi_progress = false) { void print_progress(bool from_multi_progress = false) {
std::lock_guard<std::mutex> lock{mutex_}; std::lock_guard<std::mutex> lock{mutex_};
@@ -171,7 +191,10 @@ public:
for (auto &style : get_value<details::ProgressBarOption::font_styles>()) for (auto &style : get_value<details::ProgressBarOption::font_styles>())
details::set_font_style(os, style); details::set_font_style(os, style);
os << get_value<details::ProgressBarOption::prefix_text>(); const auto prefix_pair = get_prefix_text();
const auto prefix_text = prefix_pair.first;
const auto prefix_length = prefix_pair.second;
os << prefix_text;
os << get_value<details::ProgressBarOption::start>(); os << get_value<details::ProgressBarOption::start>();
@@ -183,11 +206,25 @@ public:
os << get_value<details::ProgressBarOption::end>(); os << get_value<details::ProgressBarOption::end>();
if (get_value<details::ProgressBarOption::max_postfix_text_len>() == 0) const auto postfix_pair = get_postfix_text();
get_value<details::ProgressBarOption::max_postfix_text_len>() = 10; const auto postfix_text = postfix_pair.first;
os << " " << get_value<details::ProgressBarOption::postfix_text>() const auto postfix_length = postfix_pair.second;
<< std::string(get_value<details::ProgressBarOption::max_postfix_text_len>(), ' ') << "\r"; os << postfix_text;
// Get length of prefix text and postfix text
const auto start_length = get_value<details::ProgressBarOption::start>().size();
const auto bar_width = get_value<details::ProgressBarOption::bar_width>();
const auto end_length = get_value<details::ProgressBarOption::end>().size();
const auto terminal_width = terminal_size().second;
// prefix + bar_width + postfix should be <= terminal_width
const int remaining = terminal_width - (prefix_length + start_length + bar_width + end_length + postfix_length);
if (remaining > 0) {
os << std::string(remaining, ' ') << "\r";
} else if (remaining < 0) {
// Do nothing. Maybe in the future truncate postfix with ...
}
os.flush(); os.flush();
if (get_value<details::ProgressBarOption::completed>() && if (get_value<details::ProgressBarOption::completed>() &&
!from_multi_progress) // Don't std::endl if calling from MultiProgress !from_multi_progress) // Don't std::endl if calling from MultiProgress
os << termcolor::reset << std::endl; os << termcolor::reset << std::endl;