zhangyiss/liblbfgs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug was fixed in delta criterion

Browse Source 
Delta criterion didn't work properly. Please, consider fix to add
This commit is contained in:
Kostyukov 2017-06-02 14:59:56 +03:00 committed by GitHub
parent 57678b188a
commit c16297a59e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/lbfgs.c
View File

@ -510,7 +510,7 @@ int lbfgs(
/* /*
Test for stopping criterion. Test for stopping criterion.
The criterion is given by the following formula: The criterion is given by the following formula:
(f(past_x) - f(x)) / f(x) < \delta |(f(past_x) - f(x))| / f(x) < \delta
*/ */
if (pf != NULL) { if (pf != NULL) {
/* We don't test the stopping criterion while k < past. */ /* We don't test the stopping criterion while k < past. */
@ -519,7 +519,7 @@ int lbfgs(
rate = (pf[k % param.past] - fx) / fx; rate = (pf[k % param.past] - fx) / fx;
/* The stopping criterion. */ /* The stopping criterion. */
if (rate < param.delta) { if (fabs(rate) < param.delta) {
ret = LBFGS_STOP; ret = LBFGS_STOP;
break; break;
} }