Commit Graph

463 Commits

Author SHA1 Message Date
Goekdeniz-Guelmez
2d2f39f96e updates 2025-03-05 14:25:55 +01:00
Goekdeniz-Guelmez
1f89453295 eos token return fix 2025-03-05 14:00:51 +01:00
Goekdeniz-Guelmez
2bde97fe13 minor speed improvement 2025-03-05 13:55:24 +01:00
Goekdeniz-Guelmez
3dfb21267b updates 2025-03-05 12:59:41 +01:00
Gökdeniz Gülmez
c817743333
Merge branch 'ml-explore:main' into adding-GRPO-training 2025-03-03 22:13:42 +01:00
Shunta Saito
269faa5fa4
Fix plamo2 model to use rms_norm (#1308)
* Fix plamo2 model to use rms_norm and enable sliding window attention

* Fix missing variable

* Remove sliding window attention impl. cause it should be done by using RotatingKVCache

* Remove unused imports
2025-03-03 06:12:02 -08:00
Goekdeniz-Guelmez
132225a018 updates 2025-03-01 22:23:33 +01:00
Goekdeniz-Guelmez
925e11439b updates 2025-02-28 22:07:24 +01:00
Gökdeniz Gülmez
80e10a59d7
Merge branch 'main' into adding-GRPO-training 2025-02-28 21:16:02 +01:00
Awni Hannun
845cd8c01e
support kimi + more options in chat mode (#1312) 2025-02-28 11:33:18 -08:00
Awni Hannun
b2108a0de6
Allow mask prompt in config (#1314) 2025-02-28 11:33:04 -08:00
Goekdeniz-Guelmez
15d53279ae batching fix 2025-02-28 16:02:40 +01:00
Gökdeniz Gülmez
a04eb02257
Merge branch 'ml-explore:main' into adding-GRPO-training 2025-02-28 11:18:32 +01:00
madroid
eb73549631
Generate: Support Prefill Response (#1299)
* Generate: Support Prefill Prompt

python -m mlx_lm.generate \
       --model mlx-community/DeepSeek-R1-Distill-Qwen-1.5B-4bit \
       --prompt "hello" \
       --prefill-prompt "<think>\n"

* Generate: rename prefill-prompt to prefill-response

* nits

---------

Co-authored-by: Awni Hannun <awni.hannun@gmail.com>
2025-02-27 07:44:00 -08:00
Gökdeniz Gülmez
f27ed26b32
Merge branch 'ml-explore:main' into adding-GRPO-training 2025-02-27 11:23:20 +01:00
Awni Hannun
00a7379070
Fixes for phi4 mini (#1305) 2025-02-26 16:21:54 -08:00
Awni Hannun
0f240a4c7e
Use max tokens from options in mlx_lm evaluate (#1302) 2025-02-26 15:46:16 -08:00
Awni Hannun
56e60ad5a6
fix manage for new transformers (#1304) 2025-02-26 15:44:57 -08:00
Pedro Cuenca
b7f742ef56
Mixed quant recipes (#1300)
* Mixed 3/6 and 2/6 recipes based on Alex Barron's

* format / nits

---------

Co-authored-by: Awni Hannun <awni.hannun@gmail.com>
2025-02-26 11:32:36 -08:00
Goekdeniz-Guelmez
fab2dc2688 smoll fix 2025-02-26 15:21:57 +01:00
Gökdeniz Gülmez
ef6ff92add
Merge branch 'ml-explore:main' into adding-GRPO-training 2025-02-25 13:26:22 +01:00
Shunta Saito
c37e26a1a3
Add plamo-2-1b model (#1283)
* Add pfnet/plamo-2-1b

* Fix cache.py to support non-top level layers

* Use mlx's BaseModelArgs

* Fix model

* Use sanitize()

* Remove unnecessary changes

* Add plamo2.py

* Apply formatter

* Fix some part

* Allow a cache obj defined externally

* Fix channel first weights to channel last for right use of MLX's conv1d

* Remove unused code part

* Give all inputs when it's the first time call of model

* Fix import

* Include .jsonl files to download from Huggingface hub

* Fix reference to layers

* Remove unnecessary code and add a test for plamo2

* Do not pass mask to prepare_inputs_for_generation

* Fix to use repeat instead of tile

* Add state property to PlamoCache

* Add __iter__ and __next__ methods to PlamoCache

* cleanup

* cleanup

* fix

---------

Co-authored-by: Awni Hannun <awni.hannun@gmail.com>
2025-02-24 19:24:43 -08:00
Goekdeniz-Guelmez
53185c7f3d last update, gn 2025-02-24 22:20:07 +01:00
Goekdeniz-Guelmez
e4eac9c97b adding custom system message integration in dataset, more opimizations (generates now faster, while same RAM usage), fix for the identical generatrions, seperated the reward functions into a seperate file. 2025-02-24 20:49:22 +01:00
Gökdeniz Gülmez
bd5f081ca5
Merge branch 'ml-explore:main' into adding-GRPO-training 2025-02-22 19:11:26 +01:00
Goekdeniz-Guelmez
c0bd89aa15 add usage in LORA.md 2025-02-22 17:29:06 +01:00
Goekdeniz-Guelmez
9705ed908e fix wrong generation in train 2025-02-22 17:21:08 +01:00
Goekdeniz-Guelmez
d9c4c6e60c clean up and readding temperature argument 2025-02-22 02:34:56 +01:00
Goekdeniz-Guelmez
d653371e3d nits 2025-02-22 02:12:02 +01:00
Goekdeniz-Guelmez
235348c211 generation speed improvement in training too from 3 t/s to 15 t/s 2025-02-22 02:03:01 +01:00
Goekdeniz-Guelmez
79de353530 nits 2025-02-22 01:05:58 +01:00
Goekdeniz-Guelmez
c51b0a2715 fix 2025-02-22 00:21:47 +01:00
Goekdeniz-Guelmez
710bc1490e training mode working too got from 2 toks/sec to 30 toks/sec with raw 1.5B model 2025-02-21 22:42:15 +01:00
Goekdeniz-Guelmez
6086137131 Huge speed improvement in validation mode. 2025-02-21 22:08:49 +01:00
Goekdeniz-Guelmez
2f20107d9b little faster generation + prints ot a examplke generatino in validation mode, more optimization in trianing function 2025-02-21 16:02:27 +01:00
Awni Hannun
3d793ecf68
Fix logits processor bugs with spec dec (#1291)
* Fix logits processor bugs with spec dec

* bump patch
2025-02-20 15:55:55 -08:00
Awni Hannun
85669451d0
Fix num layers in fine tune (#1294) 2025-02-20 13:32:01 -08:00
Goekdeniz-Guelmez
541f0be937 fix generation cutoff in evaluation 2025-02-17 14:39:38 +01:00
Gökdeniz Gülmez
1eea135a20
Merge branch 'ml-explore:main' into adding-GRPO-training 2025-02-17 14:25:03 +01:00
Goekdeniz-Guelmez
6a6bd53e43 removing print and switching some variables in the math 2025-02-15 15:38:51 +01:00
Goekdeniz-Guelmez
5ec4790656 removing comments + adding temperature + reward weighting 2025-02-15 15:29:22 +01:00
Goekdeniz-Guelmez
baeb9f117f reduncancy fix + nits 2025-02-14 09:09:59 +01:00
Matthias Neumayer
96bf37008e
Update README.md to include how to set temperature (#1280)
* Update README.md to include how to set temperature

* nits

---------

Co-authored-by: Awni Hannun <awni@apple.com>
2025-02-13 19:32:56 -08:00
Awni Hannun
7b07b14e67
add logits processor to spec gen (#1260) 2025-02-13 19:19:53 -08:00
Goekdeniz-Guelmez
65a49dda0e nits 2025-02-13 21:46:30 +01:00
Goekdeniz-Guelmez
8179b99436 quick prompting fix 2025-02-12 19:24:35 +01:00
Goekdeniz-Guelmez
a7273f6a56 small fix 2025-02-12 18:30:12 +01:00
Gökdeniz Gülmez
3823154014
Merge branch 'ml-explore:main' into adding-GRPO-training 2025-02-12 11:10:10 +01:00
Goekdeniz-Guelmez
e33d9d509b updates 2025-02-12 11:07:53 +01:00
Goekdeniz-Guelmez
c42e858d7e Merge branch 'adding-GRPO-training' of https://github.com/Goekdeniz-Guelmez/mlx-examples into adding-GRPO-training 2025-02-12 08:57:33 +01:00