Commit Graph

383 Commits

Author SHA1 Message Date
Goekdeniz-Guelmez
b1c1e1353e nice printing the test metrics 2025-02-04 11:19:59 +01:00
Goekdeniz-Guelmez
069431bd65 adding test_ppl in testing 2025-02-04 11:18:09 +01:00
Goekdeniz-Guelmez
43f2451973 nits 2025-02-04 11:02:59 +01:00
Goekdeniz-Guelmez
c2fcb6738b fix testing 2025-02-04 11:02:00 +01:00
Gökdeniz Gülmez
9b489a6c0c
Merge branch 'ml-explore:main' into adding-dpo-training 2025-02-04 10:45:50 +01:00
Awni Hannun
21d0ab6e8a
fix deepseek sharding (#1242) 2025-02-03 16:59:50 -08:00
Gökdeniz Gülmez
0989c073b0
Optimizations for mamba1 (#1213)
* added mx.einsum() operations: before: 41.293 tokens-per-sec, after: 57.822 tokens-per-sec

* Fused Operations in delta, B, C = ... :. Before: 57.822 tokens-per-sec, after: 83.890 tokens-per-sec

* Pre-computing A_log. After: 83.890 tokens-per-sec, before: 85.848 tokens-per-sec

* Update MambaBlock, Batched Input Processing, Improved Cache Handling, Pre-computed Constants, Cleaner State Management, Explicit Return Values:. Before: 82.442 tokens-per-sec, after: 129.130 tokens-per-sec.

* cleaning up and adding apple copyright to helium modelfile

* update Copyright to this year

* nits + even faster

---------

Co-authored-by: Awni Hannun <awni.hannun@gmail.com>
2025-02-03 13:36:08 -08:00
Awni Hannun
d9924d08d1
Fix no validation in lora (#1241) 2025-02-03 09:55:24 -08:00
Awni Hannun
9c2ef38d4d
only download local shard (#1240) 2025-02-02 13:58:44 -08:00
Goekdeniz-Guelmez
fbb51f651a small fix 2025-02-01 16:08:52 +01:00
Goekdeniz-Guelmez
a03d434bb9 clean up 2025-01-31 21:37:15 +01:00
Goekdeniz-Guelmez
5998272ec2 cleaning up some namings 2025-01-31 21:27:59 +01:00
Goekdeniz-Guelmez
b379359385 small fix 2025-01-31 17:19:55 +01:00
Goekdeniz-Guelmez
b31d9cbb65 removing is-reference-free argument 2025-01-31 00:01:49 +01:00
Gökdeniz Gülmez
b3d6fc38cd
Merge branch 'ml-explore:main' into adding-dpo-training 2025-01-29 15:07:37 +01:00
Awni Hannun
e8afb59de4
better overflow correction (#1229) 2025-01-28 14:37:30 -08:00
Anchen
7a83077cd7
chore(mlx-lm): support text type content in messages (#1225)
* chore(mlx-lm): support text type content

* chore: optimize the messagef content processing

* nits + format

---------

Co-authored-by: Awni Hannun <awni@apple.com>
2025-01-27 17:13:50 -08:00
Awni Hannun
f44a52e2dc
batched min p and fix spec gen sampling (#1222) 2025-01-27 15:40:31 -08:00
Gökdeniz Gülmez
9e5482ee74
Merge branch 'main' into adding-dpo-training 2025-01-26 17:01:37 +01:00
Gökdeniz Gülmez
77faa14ba4
adding support for kyutai's helium (#1208)
* initial commit

* adding helium into training

* Update ACKNOWLEDGMENTS.md

* nits

* nits

* fixes / nits

---------

Co-authored-by: Awni Hannun <awni@apple.com>
2025-01-26 07:19:07 -08:00
Goekdeniz-Guelmez
557649d8da removing tokenizer and updates 2025-01-26 15:25:27 +01:00
Goekdeniz-Guelmez
4d0e52f7c8 more metrics 2025-01-26 15:09:55 +01:00
Goekdeniz-Guelmez
0ff1289bd9 updates 2025-01-25 22:03:32 +01:00
Goekdeniz-Guelmez
86b315fdf9 nits and quality of life improvements 2025-01-24 22:40:27 +01:00
Goekdeniz-Guelmez
531c3345c6 nits 2025-01-24 18:13:05 +01:00
Goekdeniz-Guelmez
54fcd8ed63 update DPODataset and added in system field too 2025-01-24 18:11:56 +01:00
Goekdeniz-Guelmez
aefe4ba160 nits 2025-01-22 21:36:56 +01:00
Goekdeniz-Guelmez
e1d549bcd3 nits 2025-01-22 21:03:21 +01:00
Goekdeniz-Guelmez
b0ece88909 nits 2025-01-22 20:54:31 +01:00
Gökdeniz Gülmez
69a8f11f7b
Merge branch 'ml-explore:main' into adding-dpo-training 2025-01-22 14:18:24 +01:00
Awni Hannun
9a3ddc3e65
some fixes for pipeline parallel deep seek r1 (#1216) 2025-01-21 19:40:29 -08:00
Victor Nogueira
df1406735b
Fix dataset variable name, in datasets.py (#1212) 2025-01-21 14:12:43 -08:00
Goekdeniz-Guelmez
477000ec9d removing unneeded functions 2025-01-19 01:13:17 +01:00
Goekdeniz-Guelmez
06a9f5d106 update lora_config.yaml 2025-01-19 00:53:41 +01:00
Goekdeniz-Guelmez
1b4e19675d update LORA.md 2025-01-19 00:48:45 +01:00
Goekdeniz-Guelmez
582f979dfd fixing reference model loading and freezing 2025-01-19 00:41:27 +01:00
Goekdeniz-Guelmez
1ff788821c initial commit 2025-01-19 00:19:36 +01:00
Jarrett
07f88f8057
fix(lora): add back store_true default args (#1205) 2025-01-16 11:15:42 -08:00
Awni Hannun
50f0a7f6d9
add internlm3 (#1206) 2025-01-15 14:55:41 -08:00
Ivan Fioravanti
6ae6c72c2e
reduction moved to CPU in case of distributed training (#1200) 2025-01-14 17:20:42 -08:00
Awni Hannun
c117af83b8
fix gpt bigcode (#1204) 2025-01-13 10:22:32 -08:00
Chime Ogbuji
0228c46434
Custom local dataset features (#1085)
* Generalize prompt_feature and completion_feature for use in local datasets to facilitate compatibility with many other training dataset formats.

* Persist configured prompt/completion key

* rebase + nits

---------

Co-authored-by: Awni Hannun <awni@apple.com>
2025-01-13 10:01:18 -08:00
Prince Canuma
bf2da36fc6
Fix Cohere2: mask shape error (long context) (#1202)
* fix mask shape error (long context)

* Update llms/mlx_lm/models/cohere2.py

Co-authored-by: Awni Hannun <awni.hannun@gmail.com>

* revert layer_idx

* black formatting

* Update cohere2.py

* format

---------

Co-authored-by: Awni Hannun <awni.hannun@gmail.com>
Co-authored-by: Awni Hannun <awni@apple.com>
2025-01-12 12:58:08 -08:00
Xingjun.Wang
514502da22
Support snapshot_download for ModelScope (#1194)
* add MLX_USE_MODELSCOPE env

* update

* update snapshot_download

* update

* remove modelscope dependency and add import check

* update

* nits

* fix

---------

Co-authored-by: wangxingjun778 <jason@U-C7X6TX5G-2239.local>
Co-authored-by: Awni Hannun <awni@apple.com>
2025-01-10 15:29:34 -08:00
Awni Hannun
93c5cfd781
Add a speculative decoding generator (#1155)
* add a speculative decoding generator

* fix

* fixes

* optional kwarg pop
2025-01-10 15:27:08 -08:00
Awni Hannun
5cae0a60e6
deepseek v3 model with pipeline parallelism (#1191)
* deepseekv3

* use upload_large_file instead of deprecated multi comit

* add pipeline generation and example

* comment

* get fp16 working

* use mlx==0.22
2025-01-09 15:55:53 -08:00
Jarrett
40b88eff48
fix(lora): config yaml & arg default merge bug (#1196) 2025-01-09 11:33:54 -08:00
Pedro Cuenca
b8f0cacfa8
Use upload_large_folder (#1193) 2025-01-07 09:18:31 -08:00
Awni Hannun
9183fe8b6d
fix (#1192) 2025-01-06 10:12:07 -08:00
Chime Ogbuji
f2619f507c
Add support for fewshot and apply chat template lm_eval functionality (#1180)
* Add support for multiturn fewshot examples and chat templates

Added two new arguments to the evaluation script: `--fewshot-as-multiturn` and `--apply-chat-template` which correspond to lm_eval options of similar names and are very often used to ensure apples-to-apples comparisons of lm_evaluation results

* Add HF overrides for methods needed by added options

* don't add duplicate bos

---------

Co-authored-by: Awni Hannun <awni@apple.com>
2025-01-06 07:58:43 -08:00