zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-10-19 16:48:10 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix grad copies (#1854)

Browse Source 
* fix grad with copies

* add test

* add test
This commit is contained in:
Awni Hannun
2025-02-11 15:26:42 -08:00
committed by GitHub
parent 2a45056ba8
commit 0a5215693e
2 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
python/src/transforms.cpp
View File

@@ -171,12 +171,12 @@ auto py_value_and_grad(
nb::list tree;
tree.append(args);
tree.append(kwargs);
tree_replace(tree, arrays, a);
tree_fill(tree, a);
// Call the python function
py_value_out = fun(*tree[0], **tree[1]);
tree_replace(tree, arrays, a);
tree_fill(tree, arrays);
// Validate the return value of the python function
if (!nb::isinstance<mx::array>(py_value_out)) {