zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-08-21 20:46:46 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Ensure no oob read in gemv_masked (#2508)

Browse Source
This commit is contained in:
Angelos Katharopoulos 2025-08-17 08:42:33 -07:00 committed by GitHub
parent 73f22d6226
commit 1df9887998
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 49 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
mlx/backend/metal/kernels/gemv_masked.h
View File

@ -262,10 +262,10 @@ struct GEMVKernel {
vec_mask_offset += vec_mask_step; vec_mask_offset += vec_mask_step;
} }
if (leftover > 0 && if (leftover > 0) {
(!has_operand_mask || if (!has_operand_mask ||
(bool(mat_mask[mat_mask_offset]) && (bool(mat_mask[mat_mask_offset]) &&
bool(vec_mask[vec_mask_offset])))) { bool(vec_mask[vec_mask_offset]))) {
T block_scale{1}; T block_scale{1};
if (has_mul_operand_mask) { if (has_mul_operand_mask) {
block_scale = block_scale =
@ -295,6 +295,7 @@ struct GEMVKernel {
} }
} }
} }
}
// Apply out scale // Apply out scale
if (has_mul_output_mask) { if (has_mul_output_mask) {
@ -544,10 +545,10 @@ struct GEMVTKernel {
vec_mask_offset += vec_mask_step; vec_mask_offset += vec_mask_step;
} }
if (leftover > 0 && if (leftover > 0) {
(!has_operand_mask || if (!has_operand_mask ||
(bool(mat_mask[mat_mask_offset]) && (bool(mat_mask[mat_mask_offset]) &&
bool(vec_mask[vec_mask_offset])))) { bool(vec_mask[vec_mask_offset]))) {
T block_scale{1}; T block_scale{1};
if (has_mul_operand_mask) { if (has_mul_operand_mask) {
block_scale = block_scale =
@ -573,6 +574,7 @@ struct GEMVTKernel {
} }
} }
} }
}
// Apply out scale // Apply out scale
if (has_mul_output_mask) { if (has_mul_output_mask) {