zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-06-24 17:31:16 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

C++20 compatibility for fmt (#1519)

Browse Source 
* C++20 compatibility for fmt

* Address review feedback

* Remove stray string

* Add newlines back
This commit is contained in:
xnorai 2024-10-24 08:54:51 -07:00 committed by GitHub
parent f6afb9c09b
commit 32972a5924
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mlx/backend/metal/indexing.cpp
View File

@ -262,7 +262,7 @@ void Scatter::eval_gpu(const std::vector<array>& inputs, array& out) {
break; break;
} }
if (reduce_type_ != Scatter::None) { if (reduce_type_ != Scatter::None) {
op_type = fmt::format(op_type, out_type_str); op_type = fmt::format(fmt::runtime(op_type), out_type_str);
} }
auto [idx_args, idx_arr] = make_index_args(idx_type_str, nidx); auto [idx_args, idx_arr] = make_index_args(idx_type_str, nidx);

5
mlx/backend/metal/jit_kernels.cpp
View File

@ -445,8 +445,9 @@ MTL::ComputePipelineState* get_steel_gemm_splitk_accum_kernel(
kernel_source << metal::utils() << metal::gemm() kernel_source << metal::utils() << metal::gemm()
<< metal::steel_gemm_splitk() << metal::steel_gemm_splitk()
<< fmt::format( << fmt::format(
axbpy ? steel_gemm_splitk_accum_axbpy_kernels fmt::runtime(
: steel_gemm_splitk_accum_kernels, axbpy ? steel_gemm_splitk_accum_axbpy_kernels
: steel_gemm_splitk_accum_kernels),
"name"_a = lib_name, "name"_a = lib_name,
"atype"_a = get_type_string(in.dtype()), "atype"_a = get_type_string(in.dtype()),
"otype"_a = get_type_string(out.dtype())); "otype"_a = get_type_string(out.dtype()));

8
mlx/backend/metal/kernels.h
View File

@ -209,10 +209,10 @@ get_template_definition(std::string name, std::string func, Args... args) {
}; };
(add_arg(args), ...); (add_arg(args), ...);
s << ">"; s << ">";
std::string base_string = R"( return fmt::format(
template [[host_name("{0}")]] [[kernel]] decltype({1}) {1}; "\ntemplate [[host_name(\"{0}\")]] [[kernel]] decltype({1}) {1};\n",
)"; name,
return fmt::format(base_string, name, s.str()); s.str());
} }
} // namespace mlx::core } // namespace mlx::core