zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-12-16 01:49:05 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Remove unnecessary string copies (#891)

Browse Source 
1. Use string_view instead of string when there is no need for copy.
2. Otherwise move string when possible.
This commit is contained in:
Cheng
2024-03-29 05:14:59 +09:00
committed by GitHub
parent 45f636e759
commit 46caf0bef0
11 changed files with 36 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
mlx/io/gguf_quants.cpp
View File

@@ -105,7 +105,7 @@ void gguf_load_quantized(
weights_per_byte = 1;
}
std::string name = std::string(tensor.name, tensor.namelen);
std::string name(tensor.name, tensor.namelen);
std::vector<int> shape = get_shape(tensor);
const uint64_t weights_per_block = 32;
if (shape[shape.size() - 1] % weights_per_block != 0) {
@@ -136,9 +136,9 @@ void gguf_load_quantized(
extract_q8_0_data(tensor, weights, scales, biases);
}
a.insert({name, weights});
a.emplace(std::move(name), std::move(weights));
auto check_insert = [](auto inserted) {
auto check_insert = [](const auto& inserted) {
if (!inserted.second) {
std::ostringstream msg;
msg << "[load_gguf] Duplicate parameter name " << inserted.first->second
@@ -147,11 +147,11 @@ void gguf_load_quantized(
}
};
const std::string weight_suffix = ".weight";
constexpr std::string_view weight_suffix = ".weight";
const std::string name_prefix =
name.substr(0, name.length() - weight_suffix.length());
check_insert(a.insert({name_prefix + ".scales", scales}));
check_insert(a.insert({name_prefix + ".biases", biases}));
check_insert(a.emplace(name_prefix + ".scales", std::move(scales)));
check_insert(a.emplace(name_prefix + ".biases", std::move(biases)));
}
} // namespace mlx::core