zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-12-16 01:49:05 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Remove unnecessary string copies (#891)

Browse Source 
1. Use string_view instead of string when there is no need for copy.
2. Otherwise move string when possible.
This commit is contained in:
Cheng
2024-03-29 05:14:59 +09:00
committed by GitHub
parent 45f636e759
commit 46caf0bef0
11 changed files with 36 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mlx/linalg.cpp
View File

@@ -96,7 +96,7 @@ inline array matrix_norm(
inline array matrix_norm(
const array& a,
const std::string& ord,
std::string_view ord,
const std::vector<int>& axis,
bool keepdims,
StreamOrDevice s) {
@@ -153,7 +153,7 @@ array norm(
array norm(
const array& a,
const std::string& ord,
std::string_view ord,
const std::optional<std::vector<int>>& axis /* = std::nullopt */,
bool keepdims /* = false */,
StreamOrDevice s /* = {} */) {