zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-06-25 09:51:17 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix complex power and print

Browse Source
This commit is contained in:
Awni Hannun 2025-06-13 07:22:03 -07:00
parent c8b4787e4e
commit 4a01d2d5d3
4 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mlx/backend/cuda/device/binary_ops.cuh
View File

@ -194,6 +194,13 @@ struct Power {
} }
return res; return res;
} else if constexpr (cuda::std::is_same_v<T, cuComplex>) { } else if constexpr (cuda::std::is_same_v<T, cuComplex>) {
if (base.y == 0 && base.x == 0) {
if (isnan(exp.x) || isnan(exp.y)) {
auto nan = cuda::std::numeric_limits<T>::quiet_NaN();
return make_cuFloatComplex(nan, nan);
}
return make_cuFloatComplex(0.0, 0.0);
}
auto x_theta = atan2f(base.y, base.x); auto x_theta = atan2f(base.y, base.x);
auto x_ln_r = 0.5 * logf(base.x * base.x + base.y * base.y); auto x_ln_r = 0.5 * logf(base.x * base.x + base.y * base.y);
auto mag = expf(exp.x * x_ln_r - exp.y * x_theta); auto mag = expf(exp.x * x_ln_r - exp.y * x_theta);

7
mlx/backend/metal/kernels/binary_ops.h
View File

@ -235,6 +235,13 @@ struct Power {
template <> template <>
complex64_t operator()(complex64_t x, complex64_t y) { complex64_t operator()(complex64_t x, complex64_t y) {
if (x.real == 0 && x.imag == 0) {
if (metal::isnan(y.real) || metal::isnan(y.imag)) {
auto nan = metal::numeric_limits<float>::quiet_NaN();
return {nan, nan};
}
return {0.0, 0.0};
}
auto x_theta = metal::atan2(x.imag, x.real); auto x_theta = metal::atan2(x.imag, x.real);
auto x_ln_r = 0.5 * metal::log(x.real * x.real + x.imag * x.imag); auto x_ln_r = 0.5 * metal::log(x.real * x.real + x.imag * x.imag);
auto mag = metal::exp(y.real * x_ln_r - y.imag * x_theta); auto mag = metal::exp(y.real * x_ln_r - y.imag * x_theta);

7
mlx/utils.cpp
View File

@ -69,7 +69,12 @@ inline void PrintFormatter::print(std::ostream& os, double val) {
os << val; os << val;
} }
inline void PrintFormatter::print(std::ostream& os, complex64_t val) { inline void PrintFormatter::print(std::ostream& os, complex64_t val) {
os << val; os << val.real();
if (val.imag() >= 0 || std::isnan(val.imag())) {
os << "+" << val.imag() << "j";
} else {
os << "-" << -val.imag() << "j";
}
} }
PrintFormatter& get_global_formatter() { PrintFormatter& get_global_formatter() {

7
python/tests/test_ops.py
View File

@ -3078,6 +3078,13 @@ class TestOps(mlx_tests.MLXTestCase):
) )
self.assertTrue(np.allclose(mx.rsqrt(x), 1.0 / np.sqrt(x))) self.assertTrue(np.allclose(mx.rsqrt(x), 1.0 / np.sqrt(x)))
def test_complex_power(self):
out = mx.power(mx.array(0j), 2)
self.assertEqual(out.item(), 0j)
out = mx.power(mx.array(0j), float("nan"))
self.assertTrue(mx.isnan(out))
class TestBroadcast(mlx_tests.MLXTestCase): class TestBroadcast(mlx_tests.MLXTestCase):
def test_broadcast_shapes(self): def test_broadcast_shapes(self):