zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-07-16 22:11:15 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make it work even for donated inputs

Browse Source
This commit is contained in:
Angelos Katharopoulos 2024-08-29 01:52:56 -07:00
parent 794a48a9f6
commit 4aefacf0bc
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
mlx/distributed/sockets/sockets.cpp
View File

@ -248,8 +248,22 @@ void all_sum(Group group_, const array& input_, array& output) {
throw std::runtime_error("Only pairwise communication supported for now"); throw std::runtime_error("Only pairwise communication supported for now");
} }
array input = ensure_row_contiguous(input_); array input = ensure_row_contiguous(input_);
// Donation not supported
if (input.data<void>() == output.data<void>()) { if (input.data<void>() == output.data<void>()) {
throw std::runtime_error("Donation not supported"); array temp(
allocator::malloc_or_wait(output.nbytes()),
output.shape(),
output.dtype());
if (group->rank() == 0) {
group->send(input.data<char>(), input.nbytes(), 1);
group->recv(temp.data<char>(), output.nbytes(), 1);
sum_inplace(temp, output);
} else {
group->recv(temp.data<char>(), output.nbytes(), 0);
group->send(input.data<char>(), input.nbytes(), 0);
sum_inplace(temp, output);
}
} else { } else {
if (group->rank() == 0) { if (group->rank() == 0) {
group->send(input.data<char>(), input.nbytes(), 1); group->send(input.data<char>(), input.nbytes(), 1);