mirror of
https://github.com/ml-explore/mlx.git
synced 2025-12-16 01:49:05 +08:00
Do vectorized store/load in ternary ops
This commit is contained in:
@@ -15,12 +15,33 @@ namespace cu {
|
|||||||
|
|
||||||
namespace cg = cooperative_groups;
|
namespace cg = cooperative_groups;
|
||||||
|
|
||||||
template <typename Op, typename T, typename IdxT>
|
template <typename Op, typename T, typename IdxT, int N_READS>
|
||||||
__global__ void
|
__global__ void
|
||||||
ternary_v(const bool* a, const T* b, const T* c, T* out, IdxT size) {
|
ternary_v(const bool* a, const T* b, const T* c, T* out, IdxT size) {
|
||||||
IdxT index = cg::this_grid().thread_rank();
|
IdxT index = cg::this_grid().thread_rank();
|
||||||
if (index < size) {
|
int remaining = size - index * N_READS;
|
||||||
out[index] = Op{}(a[index], b[index], c[index]);
|
if (remaining <= 0) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (remaining < N_READS) {
|
||||||
|
for (int i = 0; i < remaining; ++i) {
|
||||||
|
IdxT offset = index * N_READS + i;
|
||||||
|
out[offset] = Op{}(a[offset], b[offset], c[offset]);
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
auto a_vec = load_vector<N_READS>(a, index);
|
||||||
|
auto b_vec = load_vector<N_READS>(b, index);
|
||||||
|
auto c_vec = load_vector<N_READS>(c, index);
|
||||||
|
|
||||||
|
AlignedVector<Out, N_READS> out_vec;
|
||||||
|
#pragma unroll
|
||||||
|
for (int i = 0; i < N_READS; ++i) {
|
||||||
|
out_vec.val[i] = CastOp<In, Out>{}(a_vec.val[i]);
|
||||||
|
out_vec.val[i] = Op{}(a_vec.val[i], b_vec.val[i], c_vec.val[i]);
|
||||||
|
}
|
||||||
|
|
||||||
|
store_vector<N_READS>(out, index, out_vec);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -151,9 +172,16 @@ void ternary_op_gpu_inplace(
|
|||||||
} else {
|
} else {
|
||||||
dispatch_bool(out.data_size() > INT32_MAX, [&](auto large) {
|
dispatch_bool(out.data_size() > INT32_MAX, [&](auto large) {
|
||||||
using IdxT = std::conditional_t<large(), int64_t, uint32_t>;
|
using IdxT = std::conditional_t<large(), int64_t, uint32_t>;
|
||||||
auto kernel = cu::ternary_v<Op, DType, IdxT>;
|
// TODO: Choose optimized value based on type size.
|
||||||
|
constexpr int N_READS = 4;
|
||||||
|
auto kernel = cu::ternary_v<Op, DType, IdxT, N_READS>;
|
||||||
auto [num_blocks, block_dims] = get_launch_args(
|
auto [num_blocks, block_dims] = get_launch_args(
|
||||||
kernel, out.data_size(), out.shape(), out.strides(), large());
|
kernel,
|
||||||
|
out.data_size(),
|
||||||
|
out.shape(),
|
||||||
|
out.strides(),
|
||||||
|
large(),
|
||||||
|
N_READS);
|
||||||
encoder.add_kernel_node(
|
encoder.add_kernel_node(
|
||||||
kernel,
|
kernel,
|
||||||
num_blocks,
|
num_blocks,
|
||||||
|
|||||||
Reference in New Issue
Block a user