zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-12-16 01:49:05 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix jit scan when output doesn't have primitive (#1190)

Browse Source
This commit is contained in:
Awni Hannun
2024-06-06 07:24:58 -07:00
committed by GitHub
parent 496315fe1d
commit 578842954c
4 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
mlx/backend/metal/scan.cpp
View File

@@ -38,22 +38,25 @@ void Scan::eval_gpu(const std::vector<array>& inputs, array& out) {
kname << "reverse_";
}
kname << ((inclusive_) ? "inclusive_" : "exclusive_");
std::string reduce_type;
switch (reduce_type_) {
case Scan::Sum:
kname << "sum_";
reduce_type = "sum";
break;
case Scan::Prod:
kname << "prod_";
reduce_type = "prod";
break;
case Scan::Max:
kname << "max_";
reduce_type = "max";
break;
case Scan::Min:
kname << "min_";
reduce_type = "min";
break;
}
kname << type_to_name(in) << "_" << type_to_name(out);
auto kernel = get_scan_kernel(d, kname.str(), reverse_, inclusive_, in, out);
kname << reduce_type << "_" << type_to_name(in) << "_" << type_to_name(out);
auto kernel = get_scan_kernel(
d, kname.str(), reverse_, inclusive_, reduce_type, in, out);
if (contiguous) {
auto& compute_encoder = d.get_command_encoder(s.index);