zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-07-31 07:12:20 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove unused code in Convolution::vjp (#2408)

Browse Source
This commit is contained in:
Cheng 2025-07-23 22:11:00 +09:00 committed by GitHub
parent 28d068bce6
commit 588854195f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
mlx/primitives.cpp
View File

@ -1271,19 +1271,6 @@ std::vector<array> Convolution::vjp(
has_neg_padding |= (pd < 0); has_neg_padding |= (pd < 0);
} }
auto padding_lo_ = std::vector<int>(padding_lo);
auto padding_hi_ = std::vector<int>(padding_hi);
// Use negative padding on the gradient output
if (has_neg_padding) {
for (auto& p : padding_lo_) {
p = std::max(0, p);
}
for (auto& p : padding_hi_) {
p = std::max(0, p);
}
}
auto wt_trans = group_transpose(wt, 0, 1, -1); auto wt_trans = group_transpose(wt, 0, 1, -1);
auto grad = conv_general( auto grad = conv_general(
/* const array& input = */ cotan, /* const array& input = */ cotan,
@ -1305,12 +1292,9 @@ std::vector<array> Convolution::vjp(
for (int i = 0; i < grad.ndim() - 2; i++) { for (int i = 0; i < grad.ndim() - 2; i++) {
if (padding_lo[i] < 0) { if (padding_lo[i] < 0) {
starts[i + 1] -= padding_lo[i]; starts[i + 1] -= padding_lo[i];
padding_lo[i] = 0;
} }
if (padding_hi[i] < 0) { if (padding_hi[i] < 0) {
stops[i + 1] += padding_hi[i]; stops[i + 1] += padding_hi[i];
padding_hi[i] = 0;
} }
} }