zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-11-04 10:38:10 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Read/write files in binary mode (#1698)

Browse Source
This commit is contained in:
Cheng
2024-12-14 10:37:05 +09:00
committed by GitHub
parent 50f3535693
commit 635117c5d4
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
mlx/io/load.h
View File

@@ -15,6 +15,14 @@
#include "mlx/io/threadpool.h"
// Strictly we need to operate on files in binary mode (to avoid \r getting
// automatically inserted), but every modern system except for Windows no
// longer differentiates between binary and text files and for them define
// the flag as no-op.
#ifndef O_BINARY
#define O_BINARY 0
#endif
namespace mlx::core {
namespace io {
@@ -51,7 +59,8 @@ class Writer {
class ParallelFileReader : public Reader {
public:
explicit ParallelFileReader(std::string file_path)
: fd_(open(file_path.c_str(), O_RDONLY)), label_(std::move(file_path)) {}
: fd_(open(file_path.c_str(), O_RDONLY | O_BINARY)),
label_(std::move(file_path)) {}
~ParallelFileReader() override {
close(fd_);
@@ -93,7 +102,10 @@ class ParallelFileReader : public Reader {
class FileWriter : public Writer {
public:
explicit FileWriter(std::string file_path)
: fd_(open(file_path.c_str(), O_CREAT | O_WRONLY | O_TRUNC, 0644)),
: fd_(open(
file_path.c_str(),
O_CREAT | O_WRONLY | O_TRUNC | O_BINARY,
0644)),
label_(std::move(file_path)) {}
~FileWriter() override {