zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-08-17 15:46:43 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use int64_t instead of ssize_t (#1673)

Browse Source
This commit is contained in:
Cheng 2024-12-08 13:10:44 +09:00 committed by GitHub
parent 7c10c93a1f
commit 6f316b8bf5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mlx/utils.h
View File

@ -70,7 +70,7 @@ bool is_same_shape(const std::vector<array>& arrays);
template <typename T> template <typename T>
int check_shape_dim(const T dim) { int check_shape_dim(const T dim) {
constexpr bool is_signed = std::numeric_limits<T>::is_signed; constexpr bool is_signed = std::numeric_limits<T>::is_signed;
using U = std::conditional_t<is_signed, ssize_t, size_t>; using U = std::conditional_t<is_signed, int64_t, size_t>;
constexpr U min = static_cast<U>(std::numeric_limits<int>::min()); constexpr U min = static_cast<U>(std::numeric_limits<int>::min());
constexpr U max = static_cast<U>(std::numeric_limits<int>::max()); constexpr U max = static_cast<U>(std::numeric_limits<int>::max());

8
tests/utils_tests.cpp
View File

@ -67,15 +67,15 @@ TEST_CASE("test check shape dimension") {
CHECK_EQ(check_shape_dim(-4), -4); CHECK_EQ(check_shape_dim(-4), -4);
CHECK_EQ(check_shape_dim(0), 0); CHECK_EQ(check_shape_dim(0), 0);
CHECK_EQ(check_shape_dim(12), 12); CHECK_EQ(check_shape_dim(12), 12);
CHECK_EQ(check_shape_dim(static_cast<ssize_t>(dim_min)), dim_min); CHECK_EQ(check_shape_dim(static_cast<int64_t>(dim_min)), dim_min);
CHECK_EQ(check_shape_dim(static_cast<ssize_t>(dim_max)), dim_max); CHECK_EQ(check_shape_dim(static_cast<int64_t>(dim_max)), dim_max);
CHECK_EQ(check_shape_dim(static_cast<size_t>(0)), 0); CHECK_EQ(check_shape_dim(static_cast<size_t>(0)), 0);
CHECK_EQ(check_shape_dim(static_cast<size_t>(dim_max)), dim_max); CHECK_EQ(check_shape_dim(static_cast<size_t>(dim_max)), dim_max);
CHECK_THROWS_AS( CHECK_THROWS_AS(
check_shape_dim(static_cast<ssize_t>(dim_min) - 1), check_shape_dim(static_cast<int64_t>(dim_min) - 1),
std::invalid_argument); std::invalid_argument);
CHECK_THROWS_AS( CHECK_THROWS_AS(
check_shape_dim(static_cast<ssize_t>(dim_max) + 1), check_shape_dim(static_cast<int64_t>(dim_max) + 1),
std::invalid_argument); std::invalid_argument);
CHECK_THROWS_AS( CHECK_THROWS_AS(
check_shape_dim(static_cast<size_t>(dim_max) + 1), std::invalid_argument); check_shape_dim(static_cast<size_t>(dim_max) + 1), std::invalid_argument);