zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-10-31 16:21:27 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge commit from fork

Browse Source 
* add length validation to the header

* fix accessing out of bound index with .at()
This commit is contained in:
wickedcoder
2025-10-23 01:31:25 +03:00
committed by GitHub
parent 7e3471c987
commit 7707196297
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mlx/io/load.cpp
View File

@@ -265,7 +265,7 @@ array load(std::shared_ptr<io::Reader> in_stream, StreamOrDevice s) {
std::vector<char> buffer(header_len + 1); std::vector<char> buffer(header_len + 1);
in_stream->read(&buffer[0], header_len); in_stream->read(&buffer[0], header_len);
buffer[header_len] = 0; buffer[header_len] = 0;
std::string header(&buffer[0]); std::string header(buffer.data(), header_len);
// Read data type from header // Read data type from header
std::string dtype_str = header.substr(11, 3); std::string dtype_str = header.substr(11, 3);
@@ -273,7 +273,7 @@ array load(std::shared_ptr<io::Reader> in_stream, StreamOrDevice s) {
Dtype dtype = dtype_from_array_protocol(dtype_str); Dtype dtype = dtype_from_array_protocol(dtype_str);
// Read contiguity order // Read contiguity order
bool col_contiguous = header[34] == 'T'; bool col_contiguous = header.at(34) == 'T';
// Read array shape from header // Read array shape from header
Shape shape; Shape shape;