zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-12-13 08:11:38 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

add null check -- the bundleIdentifier is optional (#2709)

Browse Source 
* add null check -- the bundleIdentifier is optional

* use variable
This commit is contained in:
David Koski
2025-11-03 06:33:21 -08:00
committed by GitHub
parent ed9c6b1117
commit 78678de0cd
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mlx/backend/metal/device.cpp
View File

@@ -119,8 +119,10 @@ std::pair<MTL::Library*, NS::Error*> load_swiftpm_library(
// if SWIFTPM_BUNDLE is a framework identifier, try loading from that // if SWIFTPM_BUNDLE is a framework identifier, try loading from that
auto frameworks = NS::Bundle::allFrameworks(); auto frameworks = NS::Bundle::allFrameworks();
for (int i = 0, c = (int)frameworks->count(); i < c; i++) { for (int i = 0, c = (int)frameworks->count(); i < c; i++) {
auto bundle = reinterpret_cast<NS::Bundle*>(frameworks->object(i)); const auto bundle = reinterpret_cast<NS::Bundle*>(frameworks->object(i));
if (!strcmp(bundle->bundleIdentifier()->utf8String(), SWIFTPM_BUNDLE)) { const auto identifier = bundle->bundleIdentifier();
if (identifier != nullptr &&
!strcmp(identifier->utf8String(), SWIFTPM_BUNDLE)) {
library = try_load_framework(device, bundle->resourceURL(), lib_name); library = try_load_framework(device, bundle->resourceURL(), lib_name);
if (library != nullptr) { if (library != nullptr) {
return {library, nullptr}; return {library, nullptr};