zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-11-02 01:08:10 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge commit from fork

Browse Source 
* add tensor->weights_data validation

* add null pointer check for tensor
This commit is contained in:
wickedcoder
2025-10-23 01:31:03 +03:00
committed by GitHub
parent 9f0ba3ddf1
commit 7e3471c987
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mlx/io/gguf.cpp
View File

@@ -57,9 +57,15 @@ Shape get_shape(const gguf_tensor& tensor) {
} }
std::tuple<allocator::Buffer, Dtype> extract_tensor_data(gguf_tensor* tensor) { std::tuple<allocator::Buffer, Dtype> extract_tensor_data(gguf_tensor* tensor) {
if (tensor == nullptr) {
throw std::invalid_argument("[extract_tensor_data] Input tensor pointer is null.");
}
std::optional<Dtype> equivalent_dtype = gguf_type_to_dtype(tensor->type); std::optional<Dtype> equivalent_dtype = gguf_type_to_dtype(tensor->type);
// If there's an equivalent type, we can simply copy. // If there's an equivalent type, we can simply copy.
if (equivalent_dtype.has_value()) { if (equivalent_dtype.has_value()) {
if (tensor->weights_data == nullptr) {
throw std::runtime_error("[load_gguf] NULL tensor data pointer");
}
allocator::Buffer buffer = allocator::malloc(tensor->bsize); allocator::Buffer buffer = allocator::malloc(tensor->bsize);
memcpy( memcpy(
buffer.raw_ptr(), buffer.raw_ptr(),