From 8277e71ea98a1b4429ac988091179e20141a3177 Mon Sep 17 00:00:00 2001 From: Ronan Collobert Date: Fri, 31 Oct 2025 13:19:54 -0700 Subject: [PATCH] WIP (gpu) --- mlx/backend/gpu/primitives.cpp | 2 +- mlx/backend/gpu/slicing.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mlx/backend/gpu/primitives.cpp b/mlx/backend/gpu/primitives.cpp index ee40799df..837c898fc 100644 --- a/mlx/backend/gpu/primitives.cpp +++ b/mlx/backend/gpu/primitives.cpp @@ -51,7 +51,7 @@ void Contiguous::eval_gpu(const std::vector& inputs, array& out) { MLX_PROFILER_RANGE("Contiguous::eval_gpu"); assert(inputs.size() == 1); auto& in = inputs[0]; - constexpr size_t extra_bytes = 16384; + constexpr int64_t extra_bytes = 16384; if (in.buffer_size() <= out.nbytes() + extra_bytes && (in.flags().row_contiguous || (allow_col_major_ && in.flags().col_contiguous))) { diff --git a/mlx/backend/gpu/slicing.cpp b/mlx/backend/gpu/slicing.cpp index fde2a01cd..76c8b843c 100644 --- a/mlx/backend/gpu/slicing.cpp +++ b/mlx/backend/gpu/slicing.cpp @@ -11,7 +11,7 @@ void slice_gpu( array& out, const Shape& start_indices, const Shape& strides, - const Stream& s) { + const Stream& /* s */) { slice(in, out, start_indices, strides); } @@ -27,7 +27,7 @@ void pad_gpu( // Find offset for start of input values size_t data_offset = 0; - for (int i = 0; i < axes.size(); i++) { + for (int i = 0; i < std::ssize(axes); i++) { auto ax = axes[i] < 0 ? out.ndim() + axes[i] : axes[i]; data_offset += out.strides()[ax] * low_pad_size[i]; }