From 82db84b899d1824f04a6ce5a1aff9b1adebebe7a Mon Sep 17 00:00:00 2001
From: Awni Hannun <awni@apple.com>
Date: Wed, 21 Aug 2024 16:05:07 -0700
Subject: [PATCH] bump nanobind + fix extension (#1344)

---
 examples/extensions/pyproject.toml   | 4 ++--
 examples/extensions/requirements.txt | 2 +-
 examples/extensions/setup.py         | 1 -
 pyproject.toml                       | 2 +-
 setup.py                             | 2 +-
 5 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/examples/extensions/pyproject.toml b/examples/extensions/pyproject.toml
index 3c27696a7..44411b9a3 100644
--- a/examples/extensions/pyproject.toml
+++ b/examples/extensions/pyproject.toml
@@ -2,7 +2,7 @@
 requires = [
   "setuptools>=42",
   "cmake>=3.24",
-  "mlx>=0.9.0",
-  "nanobind@git+https://github.com/wjakob/nanobind.git@2f04eac452a6d9142dedb957701bdb20125561e4",
+  "mlx>=0.16.2",
+  "nanobind==2.1.0",
 ]
 build-backend = "setuptools.build_meta"
diff --git a/examples/extensions/requirements.txt b/examples/extensions/requirements.txt
index 4ab5eaf93..8fe9c3383 100644
--- a/examples/extensions/requirements.txt
+++ b/examples/extensions/requirements.txt
@@ -1,4 +1,4 @@
 setuptools>=42
 cmake>=3.24
 mlx>=0.16.2
-nanobind==2.0
+nanobind==2.1.0
diff --git a/examples/extensions/setup.py b/examples/extensions/setup.py
index ab6a3c5f3..8dd1186ab 100644
--- a/examples/extensions/setup.py
+++ b/examples/extensions/setup.py
@@ -13,7 +13,6 @@ if __name__ == "__main__":
         cmdclass={"build_ext": extension.CMakeBuild},
         packages=["mlx_sample_extensions"],
         package_data={"mlx_sample_extensions": ["*.so", "*.dylib", "*.metallib"]},
-        extras_require={"dev": []},
         zip_safe=False,
         python_requires=">=3.8",
     )
diff --git a/pyproject.toml b/pyproject.toml
index 07c15ff3e..00ea87a0f 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,7 +1,7 @@
 [build-system]
 requires = [
   "setuptools>=42",
-  "nanobind@git+https://github.com/wjakob/nanobind.git@2f04eac452a6d9142dedb957701bdb20125561e4",
+  "nanobind==2.1.0",
   "cmake>=3.24",
 ]
 build-backend = "setuptools.build_meta"
diff --git a/setup.py b/setup.py
index cd3c3c21f..73814a3b3 100644
--- a/setup.py
+++ b/setup.py
@@ -176,7 +176,7 @@ if __name__ == "__main__":
         include_package_data=True,
         extras_require={
             "dev": [
-                "nanobind==2.0",
+                "nanobind==2.1.0",
                 "numpy",
                 "pre-commit",
                 "setuptools>=42",