From 89b90dcfec29910cadb49825ae4ae7a5ca6f8c9c Mon Sep 17 00:00:00 2001 From: Awni Hannun Date: Sat, 9 Dec 2023 09:36:56 -0800 Subject: [PATCH] Pr template (#99) * pr template * format fix --- .github/pull_request_template.md | 4 ++++ python/tests/test_optimizers.py | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..fafcec8e1 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,4 @@ + +Before submitting this PR, check the [contribution guidelines](CONTRIBUTING.md). + +Make sure your code is formatted: `pre-commit run --all-files`. diff --git a/python/tests/test_optimizers.py b/python/tests/test_optimizers.py index de9ab68b6..b0a3165bb 100644 --- a/python/tests/test_optimizers.py +++ b/python/tests/test_optimizers.py @@ -1,13 +1,14 @@ # Copyright © 2023 Apple Inc. -import unittest import inspect +import unittest import mlx.core as mx import mlx.optimizers as opt import mlx.utils import mlx_tests + def get_all_optimizers(): classes = dict() for name, obj in inspect.getmembers(opt): @@ -16,8 +17,10 @@ def get_all_optimizers(): classes[name] = obj return classes + optimizers_dict = get_all_optimizers() + class TestOptimizers(mlx_tests.MLXTestCase): def test_optimizers(self): params = {