zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-09-04 15:04:40 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add cpu Max nanpropagation. Fix a small fib in cpu max dispatch data types for int8/int16.

Browse Source
This commit is contained in:
Joona Havukainen
2025-07-08 16:41:56 -07:00
parent 3e885f583a
commit 8b15773206
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
mlx/backend/cpu/reduce.cpp
View File

@@ -325,7 +325,15 @@ struct MaxReduce {
}; };
template <int N, typename T> template <int N, typename T>
T operator()(simd::Simd<T, N> x) { std::enable_if_t<std::is_integral_v<T>, T> operator()(simd::Simd<T, N> x) {
return simd::max(x);
};
template <int N, typename T>
std::enable_if_t<!std::is_integral_v<T>, T> operator()(simd::Simd<T, N> x) {
if (simd::any(x != x)) {
return static_cast<T>(NAN);
}
return simd::max(x); return simd::max(x);
}; };
}; };
@@ -527,10 +535,10 @@ void Reduce::eval_cpu(const std::vector<array>& inputs, array& out) {
reduce_dispatch_min_max<uint64_t>(in, out, reduce_type_, axes_); reduce_dispatch_min_max<uint64_t>(in, out, reduce_type_, axes_);
break; break;
case int8: case int8:
reduce_dispatch_min_max<uint8_t>(in, out, reduce_type_, axes_); reduce_dispatch_min_max<int8_t>(in, out, reduce_type_, axes_);
break; break;
case int16: case int16:
reduce_dispatch_min_max<uint16_t>(in, out, reduce_type_, axes_); reduce_dispatch_min_max<int16_t>(in, out, reduce_type_, axes_);
break; break;
case int32: case int32:
reduce_dispatch_min_max<int32_t>(in, out, reduce_type_, axes_); reduce_dispatch_min_max<int32_t>(in, out, reduce_type_, axes_);