zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-09-05 07:34:42 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Align mlx::core::min op nan propagation with NumPy (#2346)

Browse Source
This commit is contained in:
jhavukainen
2025-07-10 06:20:43 -07:00
committed by GitHub
parent 85873cb162
commit 8c7bc30ce4
5 changed files with 62 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
python/tests/test_reduce.py
View File

@@ -173,7 +173,7 @@ class TestReduce(mlx_tests.MLXTestCase):
x[idx[0], idx[1]] = mx.nan
x_np = np.array(x)
for op in ["max"]:
for op in ["max", "min"]:
for axis in [0, 1]:
out = getattr(mx, op)(x, axis=axis)
ref = getattr(np, op)(x_np, axis=axis)
@@ -205,7 +205,7 @@ class TestReduce(mlx_tests.MLXTestCase):
np_arrays,
):
for axis in [0, 1]:
for op in ["max"]:
for op in ["max", "min"]:
out = getattr(mx, op)(mx_arr, axis=axis)
ref = getattr(np, op)(np_arr, axis=axis)
self.assertTrue(np.array_equal(out, ref, equal_nan=True))