zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-08-22 13:07:51 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Changed bilinear computation to two matrix multiplications

Browse Source
This commit is contained in:
zorea 2024-01-01 00:39:52 +02:00
parent a951283561
commit 8e22ab1e5a
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
python/mlx/nn/layers/linear.py
View File

@ -119,7 +119,11 @@ class Bilinear(Module):
) )
def __call__(self, x1: mx.array, x2: mx.array) -> mx.array: def __call__(self, x1: mx.array, x2: mx.array) -> mx.array:
y = (x1 @ self.weight * x2).sum(-1).T x1 = x1.reshape(x1.shape[0], 1, 1, x1.shape[1])
x2 = x2.reshape(x2.shape[0], 1, x2.shape[1])
w = self.weight.reshape(1, *self.weight.shape)
z = mx.squeeze(x1 @ w, -2).swapaxes(-1, -2)
y = mx.squeeze(x2 @ z, -2)
if "bias" in self: if "bias" in self:
y = y + self.bias y = y + self.bias
return y return y