zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-06-25 01:41:17 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

minor changes (#613)

Browse Source
This commit is contained in:
Awni Hannun 2024-02-02 11:48:35 -08:00 committed by GitHub
parent 83f63f2184
commit 95b5fb8245
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 12 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
docs/src/dev/extensions.rst
View File

@ -677,9 +677,9 @@ Let's look at the overall directory structure first.
Binding to Python Binding to Python
^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^
We use PyBind11_ to build a Python API for the C++ library. Since bindings We use PyBind11_ to build a Python API for the C++ library. Since bindings for
for all needed components such as `mlx.core.array`, `mlx.core.stream`, etc. components such as :class:`mlx.core.array`, :class:`mlx.core.stream`, etc. are
are already provided, adding our :meth:`axpby` becomes very simple! already provided, adding our :meth:`axpby` is simple!
.. code-block:: C++ .. code-block:: C++
@ -927,18 +927,18 @@ Results:
We see some modest improvements right away! We see some modest improvements right away!
This operation is now good to be used to build other operations, This operation is now good to be used to build other operations, in
in :class:`mlx.nn.Module` calls, and also as a part of graph :class:`mlx.nn.Module` calls, and also as a part of graph transformations like
transformations like :meth:`grad`! :meth:`grad`!
Scripts Scripts
------- -------
.. admonition:: Download the code .. admonition:: Download the code
The full example code is available in `mlx-examples <code>`_. The full example code is available in `mlx <code>`_.
.. code: `TODO_LINK/extensions`_ .. code: `https://github.com/ml-explore/mlx/tree/main/examples/extensions/`_
.. _Accelerate: https://developer.apple.com/documentation/accelerate/blas?language=objc .. _Accelerate: https://developer.apple.com/documentation/accelerate/blas?language=objc
.. _Metal: https://developer.apple.com/documentation/metal?language=objc .. _Metal: https://developer.apple.com/documentation/metal?language=objc

2
examples/extensions/CMakeLists.txt
View File

@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.24) cmake_minimum_required(VERSION 3.27)
project(mlx_sample_extensions LANGUAGES CXX) project(mlx_sample_extensions LANGUAGES CXX)

16
mlx/io/CMakeLists.txt
View File

@ -11,14 +11,8 @@ MESSAGE(STATUS "Downloading json")
FetchContent_Declare(json URL https://github.com/nlohmann/json/releases/download/v3.11.3/json.tar.xz) FetchContent_Declare(json URL https://github.com/nlohmann/json/releases/download/v3.11.3/json.tar.xz)
FetchContent_MakeAvailable(json) FetchContent_MakeAvailable(json)
target_include_directories( target_include_directories(
mlx PUBLIC mlx PRIVATE
$<BUILD_INTERFACE:${json_SOURCE_DIR}/single_include/nlohmann> $<BUILD_INTERFACE:${json_SOURCE_DIR}/single_include/nlohmann>
$<INSTALL_INTERFACE:include/json>
)
install(
DIRECTORY ${json_SOURCE_DIR}/
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/json
COMPONENT json_source
) )
MESSAGE(STATUS "Downloading gguflib") MESSAGE(STATUS "Downloading gguflib")
@ -28,14 +22,8 @@ FetchContent_Declare(gguflib
) )
FetchContent_MakeAvailable(gguflib) FetchContent_MakeAvailable(gguflib)
target_include_directories( target_include_directories(
mlx PUBLIC mlx PRIVATE
$<BUILD_INTERFACE:${gguflib_SOURCE_DIR}> $<BUILD_INTERFACE:${gguflib_SOURCE_DIR}>
$<INSTALL_INTERFACE:include/gguflib>
)
install(
DIRECTORY ${gguflib_SOURCE_DIR}/
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/gguflib
COMPONENT gguflib_source
) )
add_library( add_library(