zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-07-27 11:31:21 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update smooth_l1_loss in losses.py (#1974)

Browse Source 
According the definition of smooth_l1_loss, the line 

diff = predictions - targets

Should be updated to 

diff = mx.abs(predictions - targets)

After the modification, the result is consistent with PyTorch smooth_l1_loss
This commit is contained in:
jiyzhang 2025-03-20 11:19:02 +08:00 committed by GitHub
parent f90206ad74
commit 95e335db7b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
python/mlx/nn/losses.py
View File

@ -373,7 +373,7 @@ def smooth_l1_loss(
f"targets shape {targets.shape}." f"targets shape {targets.shape}."
) )
diff = predictions - targets diff = mx.abs(predictions - targets)
loss = mx.where( loss = mx.where(
diff < beta, 0.5 * mx.square(diff) / beta, mx.abs(diff) - 0.5 * beta diff < beta, 0.5 * mx.square(diff) / beta, mx.abs(diff) - 0.5 * beta
) )