zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-10-31 07:58:14 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix (#1566)

Browse Source
This commit is contained in:
Awni Hannun
2024-11-06 17:10:33 -08:00
committed by GitHub
parent 726dbd9267
commit 9a3842a2d9
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mlx/backend/metal/custom_kernel.cpp
View File

@@ -75,7 +75,7 @@ void CustomKernel::eval_gpu(
MTL::Size group_dims = MTL::Size(tx, ty, tz); MTL::Size group_dims = MTL::Size(tx, ty, tz);
const auto [gx, gy, gz] = grid_; const auto [gx, gy, gz] = grid_;
MTL::Size grid_dims = MTL::Size(gx, gy, gz); MTL::Size grid_dims = MTL::Size(gx, gy, gz);
compute_encoder->dispatchThreads(grid_dims, group_dims); compute_encoder.dispatchThreads(grid_dims, group_dims);
d.add_temporaries(std::move(copies), s.index); d.add_temporaries(std::move(copies), s.index);
} }

2
mlx/backend/metal/fft.cpp
View File

@@ -738,7 +738,7 @@ void fft_op(
auto group_dims = MTL::Size(1, threadgroup_batch_size, threads_per_fft); auto group_dims = MTL::Size(1, threadgroup_batch_size, threads_per_fft);
auto grid_dims = auto grid_dims =
MTL::Size(batch_size, threadgroup_batch_size, threads_per_fft); MTL::Size(batch_size, threadgroup_batch_size, threads_per_fft);
compute_encoder->dispatchThreads(grid_dims, group_dims); compute_encoder.dispatchThreads(grid_dims, group_dims);
} }
d.add_temporaries(std::move(copies), s.index); d.add_temporaries(std::move(copies), s.index);

2
mlx/backend/metal/hadamard.cpp
View File

@@ -144,7 +144,7 @@ void Hadamard::eval_gpu(const std::vector<array>& inputs, array& out) {
MTL::Size group_dims = MTL::Size(1, threads_per, 1); MTL::Size group_dims = MTL::Size(1, threads_per, 1);
MTL::Size grid_dims = MTL::Size(batch_size, threads_per, 1); MTL::Size grid_dims = MTL::Size(batch_size, threads_per, 1);
compute_encoder->dispatchThreads(grid_dims, group_dims); compute_encoder.dispatchThreads(grid_dims, group_dims);
}; };
if (m > 1) { if (m > 1) {

2
mlx/backend/metal/scaled_dot_product_attention.cpp
View File

@@ -139,7 +139,7 @@ void sdpa_full_self_attention_metal(
MTL::Size grid_dims = MTL::Size(1, tm, batch_size_out); MTL::Size grid_dims = MTL::Size(1, tm, batch_size_out);
MTL::Size group_dims = MTL::Size(32, wm, wn); MTL::Size group_dims = MTL::Size(32, wm, wn);
compute_encoder->dispatchThreadgroups(grid_dims, group_dims); compute_encoder.dispatchThreadgroups(grid_dims, group_dims);
} }
void sdpa_vector( void sdpa_vector(