From a44b27f5f88391f637be2750ad3af4819b015d76 Mon Sep 17 00:00:00 2001
From: Cheng <zcbenz@gmail.com>
Date: Tue, 9 Sep 2025 07:41:05 +0900
Subject: [PATCH] Fix a few ccache cache miss (#2573)

* Fix ccache cache miss

* Do not define _VERSION_ in python bindings
---
 mlx/version.cpp           | 4 +---
 mlx/version.h             | 2 +-
 python/src/CMakeLists.txt | 1 -
 python/src/mlx.cpp        | 6 +++---
 setup.py                  | 3 ++-
 5 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/mlx/version.cpp b/mlx/version.cpp
index 2a8e3bc9b..b60168e0e 100644
--- a/mlx/version.cpp
+++ b/mlx/version.cpp
@@ -1,10 +1,8 @@
 // Copyright © 2025 Apple Inc.
 
-#include <string>
-
 namespace mlx::core {
 
-std::string version() {
+const char* version() {
   return MLX_VERSION;
 }
 
diff --git a/mlx/version.h b/mlx/version.h
index 6159ac305..9920f167a 100644
--- a/mlx/version.h
+++ b/mlx/version.h
@@ -15,6 +15,6 @@ namespace mlx::core {
  *
  * For dev builds, the version will include the suffix ".devYYYYMMDD+hash"
  */
-std::string version();
+const char* version();
 
 } // namespace mlx::core
diff --git a/python/src/CMakeLists.txt b/python/src/CMakeLists.txt
index f094fdfe8..0580b8783 100644
--- a/python/src/CMakeLists.txt
+++ b/python/src/CMakeLists.txt
@@ -52,7 +52,6 @@ set_target_properties(
              ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY})
 
 target_link_libraries(core PRIVATE mlx)
-target_compile_definitions(core PRIVATE _VERSION_=${MLX_VERSION})
 
 if(BUILD_SHARED_LIBS)
   if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
diff --git a/python/src/mlx.cpp b/python/src/mlx.cpp
index d89e48300..0921d2cea 100644
--- a/python/src/mlx.cpp
+++ b/python/src/mlx.cpp
@@ -2,9 +2,9 @@
 
 #include <nanobind/nanobind.h>
 
-#define STRINGIFY(x) #x
-#define TOSTRING(x) STRINGIFY(x)
+#include "mlx/version.h"
 
+namespace mx = mlx::core;
 namespace nb = nanobind;
 
 void init_mlx_func(nb::module_&);
@@ -48,5 +48,5 @@ NB_MODULE(core, m) {
   init_distributed(m);
   init_export(m);
 
-  m.attr("__version__") = TOSTRING(_VERSION_);
+  m.attr("__version__") = mx::version();
 }
diff --git a/setup.py b/setup.py
index b0636a70f..176d078fb 100644
--- a/setup.py
+++ b/setup.py
@@ -121,7 +121,8 @@ class CMakeBuild(build_ext):
             build_args += [f"-j{os.cpu_count()}"]
 
         # Avoid cache miss when building from temporary dirs.
-        os.environ["CCACHE_BASEDIR"] = os.path.abspath(self.build_temp)
+        os.environ["CCACHE_BASEDIR"] = os.path.realpath(self.build_temp)
+        os.environ["CCACHE_NOHASHDIR"] = "true"
 
         subprocess.run(
             ["cmake", ext.sourcedir, *cmake_args], cwd=build_temp, check=True