zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-06-26 02:33:21 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

use string (#976)

Browse Source
This commit is contained in:
Awni Hannun 2024-04-09 11:22:00 -07:00 committed by GitHub
parent b63ef10a7f
commit ae812350f9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mlx/io.h
View File

@ -50,7 +50,7 @@ void save_safetensors(
/** Load array map and metadata from .gguf file format */ /** Load array map and metadata from .gguf file format */
GGUFLoad load_gguf(std::string_view file, StreamOrDevice s = {}); GGUFLoad load_gguf(const std::string& file, StreamOrDevice s = {});
void save_gguf( void save_gguf(
std::string file, std::string file,

2
mlx/io/gguf.cpp
View File

@ -231,7 +231,7 @@ std::unordered_map<std::string, array> load_arrays(gguf_ctx* ctx) {
return array_map; return array_map;
} }
GGUFLoad load_gguf(std::string_view file, StreamOrDevice s) { GGUFLoad load_gguf(const std::string& file, StreamOrDevice s) {
gguf_ctx* ctx = gguf_open(file.data()); gguf_ctx* ctx = gguf_open(file.data());
if (!ctx) { if (!ctx) {
throw std::runtime_error("[load_gguf] gguf_init failed"); throw std::runtime_error("[load_gguf] gguf_init failed");

4
mlx/linalg.cpp
View File

@ -96,7 +96,7 @@ inline array matrix_norm(
inline array matrix_norm( inline array matrix_norm(
const array& a, const array& a,
std::string_view ord, const std::string& ord,
const std::vector<int>& axis, const std::vector<int>& axis,
bool keepdims, bool keepdims,
StreamOrDevice s) { StreamOrDevice s) {
@ -153,7 +153,7 @@ array norm(
array norm( array norm(
const array& a, const array& a,
std::string_view ord, const std::string& ord,
const std::optional<std::vector<int>>& axis /* = std::nullopt */, const std::optional<std::vector<int>>& axis /* = std::nullopt */,
bool keepdims /* = false */, bool keepdims /* = false */,
StreamOrDevice s /* = {} */) { StreamOrDevice s /* = {} */) {

4
mlx/linalg.h
View File

@ -38,13 +38,13 @@ inline array norm(
} }
array norm( array norm(
const array& a, const array& a,
std::string_view ord, const std::string& ord,
const std::optional<std::vector<int>>& axis = std::nullopt, const std::optional<std::vector<int>>& axis = std::nullopt,
bool keepdims = false, bool keepdims = false,
StreamOrDevice s = {}); StreamOrDevice s = {});
inline array norm( inline array norm(
const array& a, const array& a,
std::string_view ord, const std::string& ord,
int axis, int axis,
bool keepdims = false, bool keepdims = false,
StreamOrDevice s = {}) { StreamOrDevice s = {}) {