zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-07-27 20:07:59 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove static initializer of CompilerCache cache

Browse Source
This commit is contained in:
Hanyu Deng 2025-04-10 15:01:17 +08:00 committed by Awni Hannun
parent 83d320c2ea
commit b7ce3c947c
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
mlx/backend/cpu/compiled.cpp
View File

@ -40,7 +40,10 @@ struct CompilerCache {
std::shared_mutex mtx; std::shared_mutex mtx;
}; };
static CompilerCache cache{}; static CompilerCache& cache() {
static CompilerCache cache_;
return cache_;
};
// GPU compile is always available if the GPU is available and since we are in // GPU compile is always available if the GPU is available and since we are in
// this file CPU compile is also available. // this file CPU compile is also available.
@ -56,14 +59,16 @@ void* compile(
const std::string& kernel_name, const std::string& kernel_name,
const std::function<std::string(void)>& source_builder) { const std::function<std::string(void)>& source_builder) {
{ {
std::shared_lock lock(cache.mtx); std::shared_lock lock(cache().mtx);
if (auto it = cache.kernels.find(kernel_name); it != cache.kernels.end()) { if (auto it = cache().kernels.find(kernel_name);
it != cache().kernels.end()) {
return it->second; return it->second;
} }
} }
std::unique_lock lock(cache.mtx); std::unique_lock lock(cache().mtx);
if (auto it = cache.kernels.find(kernel_name); it != cache.kernels.end()) { if (auto it = cache().kernels.find(kernel_name);
it != cache().kernels.end()) {
return it->second; return it->second;
} }
std::string source_code = source_builder(); std::string source_code = source_builder();
@ -120,10 +125,10 @@ void* compile(
} }
// load library // load library
cache.libs.emplace_back(shared_lib_path); cache().libs.emplace_back(shared_lib_path);
// Load function // Load function
void* fun = dlsym(cache.libs.back().lib, kernel_name.c_str()); void* fun = dlsym(cache().libs.back().lib, kernel_name.c_str());
if (!fun) { if (!fun) {
std::ostringstream msg; std::ostringstream msg;
msg << "[Compile::eval_cpu] Failed to load compiled function " msg << "[Compile::eval_cpu] Failed to load compiled function "
@ -131,7 +136,7 @@ void* compile(
<< dlerror(); << dlerror();
throw std::runtime_error(msg.str()); throw std::runtime_error(msg.str());
} }
cache.kernels.insert({kernel_name, fun}); cache().kernels.insert({kernel_name, fun});
return fun; return fun;
} }