From c23888acd75783de52ad7bb498af7df5d120209e Mon Sep 17 00:00:00 2001 From: Awni Hannun Date: Tue, 1 Apr 2025 14:42:27 -0700 Subject: [PATCH] Fix build warning (#2033) --- mlx/backend/cpu/simd/accelerate_fp16_simd.h | 2 +- mlx/backend/cpu/simd/accelerate_simd.h | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/mlx/backend/cpu/simd/accelerate_fp16_simd.h b/mlx/backend/cpu/simd/accelerate_fp16_simd.h index 1f21d2e180..950544895d 100644 --- a/mlx/backend/cpu/simd/accelerate_fp16_simd.h +++ b/mlx/backend/cpu/simd/accelerate_fp16_simd.h @@ -17,7 +17,7 @@ struct ScalarT { #endif template <> -static constexpr int max_size = N; +inline constexpr int max_size = N; #define SIMD_FP16_DEFAULT_UNARY(op) \ template <> \ diff --git a/mlx/backend/cpu/simd/accelerate_simd.h b/mlx/backend/cpu/simd/accelerate_simd.h index a14d99103c..37b3cdbd8b 100644 --- a/mlx/backend/cpu/simd/accelerate_simd.h +++ b/mlx/backend/cpu/simd/accelerate_simd.h @@ -83,25 +83,25 @@ struct Simd { // Values chosen based on benchmarks on M3 Max // TODO: consider choosing these more optimally template <> -static constexpr int max_size = 16; +inline constexpr int max_size = 16; template <> -static constexpr int max_size = 16; +inline constexpr int max_size = 16; template <> -static constexpr int max_size = 8; +inline constexpr int max_size = 8; template <> -static constexpr int max_size = 4; +inline constexpr int max_size = 4; template <> -static constexpr int max_size = 16; +inline constexpr int max_size = 16; template <> -static constexpr int max_size = 16; +inline constexpr int max_size = 16; template <> -static constexpr int max_size = 8; +inline constexpr int max_size = 8; template <> -static constexpr int max_size = 4; +inline constexpr int max_size = 4; template <> -static constexpr int max_size = 8; +inline constexpr int max_size = 8; template <> -static constexpr int max_size = 4; +inline constexpr int max_size = 4; #define SIMD_DEFAULT_UNARY(name, op) \ template \