zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-08-24 06:16:38 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Using math defines requires switch in MSVC (#1665)

Browse Source 
* Using math defines requires switch in MSVC

* Fix more math macros

* Fix type

* Remove _MSC_VER guard for math defines
This commit is contained in:
Cheng 2024-12-09 01:16:28 +09:00 committed by GitHub
parent 6f316b8bf5
commit d0f471cff7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mlx/ops.cpp
View File

@ -1,4 +1,8 @@
// Copyright © 2023-2024 Apple Inc. // Copyright © 2023-2024 Apple Inc.
// Required for using M_PI in MSVC.
#define _USE_MATH_DEFINES
#include <algorithm> #include <algorithm>
#include <climits> #include <climits>
#include <cmath> #include <cmath>

4
mlx/primitives.cpp
View File

@ -1,4 +1,8 @@
// Copyright © 2023-2024 Apple Inc. // Copyright © 2023-2024 Apple Inc.
// Required for using M_2_SQRTPI in MSVC.
#define _USE_MATH_DEFINES
#include <algorithm> #include <algorithm>
#include <cassert> #include <cassert>
#include <cmath> #include <cmath>

3
tests/autograd_tests.cpp
View File

@ -1,5 +1,8 @@
// Copyright © 2023 Apple Inc. // Copyright © 2023 Apple Inc.
// Required for using M_2_SQRTPI in MSVC.
#define _USE_MATH_DEFINES
#include <algorithm> #include <algorithm>
#include <cmath> #include <cmath>
#include <numeric> #include <numeric>

3
tests/compile_tests.cpp
View File

@ -1,5 +1,8 @@
// Copyright © 2023-2024 Apple Inc. // Copyright © 2023-2024 Apple Inc.
// Required for using M_SQRT2 in MSVC.
#define _USE_MATH_DEFINES
#include "doctest/doctest.h" #include "doctest/doctest.h"
#include "mlx/mlx.h" #include "mlx/mlx.h"

4
tests/ops_tests.cpp
View File

@ -1,4 +1,8 @@
// Copyright © 2023-2024 Apple Inc. // Copyright © 2023-2024 Apple Inc.
// Required for using M_PI_2 in MSVC.
#define _USE_MATH_DEFINES
#include <cmath> #include <cmath>
#include <numeric> #include <numeric>