diff --git a/.circleci/config.yml b/.circleci/config.yml index fc64b004b..9c8cb31a3 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -92,10 +92,12 @@ jobs: - run: name: Install Python package command: | - CMAKE_ARGS="-DMLX_BUILD_METAL=OFF" \ + CMAKE_ARGS="-DMLX_BUILD_METAL=OFF + CMAKE_COMPILE_WARNING_AS_ERROR=ON" \ CMAKE_BUILD_PARALLEL_LEVEL=`nproc` \ python3 setup.py build_ext --inplace - CMAKE_ARGS="-DMLX_BUILD_METAL=OFF" \ + CMAKE_ARGS="-DMLX_BUILD_METAL=OFF \ + CMAKE_COMPILE_WARNING_AS_ERROR=ON" \ CMAKE_BUILD_PARALLEL_LEVEL=`nproc` \ python3 setup.py develop - run: @@ -146,7 +148,9 @@ jobs: name: Install Python package command: | source env/bin/activate - DEBUG=1 CMAKE_BUILD_PARALLEL_LEVEL=`sysctl -n hw.ncpu` pip install -e . -v + DEBUG=1 CMAKE_BUILD_PARALLEL_LEVEL=`sysctl -n hw.ncpu` \ + CMAKE_ARGS="CMAKE_COMPILE_WARNING_AS_ERROR=ON" \ + pip install -e . -v - run: name: Generate package stubs command: | diff --git a/CMakeLists.txt b/CMakeLists.txt index 50d12cdfc..0601ea292 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -77,7 +77,6 @@ include(FetchContent) cmake_policy(SET CMP0135 NEW) add_library(mlx) -set_target_properties(mlx PROPERTIES COMPILE_WARNING_AS_ERROR ON) if(MLX_BUILD_METAL) set(METAL_LIB "-framework Metal")