diff --git a/python/src/transforms.cpp b/python/src/transforms.cpp index d88bc5f19..8c8c16316 100644 --- a/python/src/transforms.cpp +++ b/python/src/transforms.cpp @@ -441,6 +441,7 @@ struct PyCompiledFun { constexpr uint64_t array_identifier = 18446744073709551557UL; constexpr uint64_t list_identifier = 18446744073709551533UL; constexpr uint64_t dict_identifier = 18446744073709551521UL; + constexpr uint64_t none_identifier = 10239356951478402889UL; // Flatten the tree with hashed constants and structure std::function recurse; @@ -476,10 +477,12 @@ struct PyCompiledFun { } else if (nb::isinstance(obj)) { auto r = nb::cast(obj); constants.push_back(*reinterpret_cast(&r)); + } else if (obj.is_none()) { + constants.push_back(none_identifier); } else { std::ostringstream msg; msg << "[compile] Function arguments must be trees of arrays " - << "or constants (floats, ints, or strings), but received " + << "or constants (floats, ints, strings, or None), but received " << "type " << type_name_str(obj) << "."; throw std::invalid_argument(msg.str()); } diff --git a/python/tests/test_compile.py b/python/tests/test_compile.py index 5eb32ce4d..31fd38588 100644 --- a/python/tests/test_compile.py +++ b/python/tests/test_compile.py @@ -1037,6 +1037,20 @@ class TestCompile(mlx_tests.MLXTestCase): self.assertEqual(inner.__doc__, c_inner.__doc__) self.assertEqual(inspect.signature(inner), inspect.signature(c_inner)) + def test_compile_with_none(self): + @mx.compile + def fun(x, y): + if y is None: + return mx.abs(x - 2.0) + else: + return mx.abs(x + y) + + out = fun(mx.array(1.0), None) + self.assertEqual(out.item(), 1.0) + + out = fun(mx.array(1.0), mx.array(2.0)) + self.assertEqual(out.item(), 3.0) + if __name__ == "__main__": mlx_tests.MLXTestRunner()