From f12f24a77c426c10157690cb177ec0bbb8bd8d27 Mon Sep 17 00:00:00 2001 From: Awni Hannun Date: Thu, 15 Aug 2024 16:39:24 -0700 Subject: [PATCH] fix compiling with space in paths (#1332) --- mlx/backend/common/make_compiled_preamble.sh | 2 +- mlx/backend/metal/make_compiled_preamble.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mlx/backend/common/make_compiled_preamble.sh b/mlx/backend/common/make_compiled_preamble.sh index 93eca9ca1..bbb1187d1 100644 --- a/mlx/backend/common/make_compiled_preamble.sh +++ b/mlx/backend/common/make_compiled_preamble.sh @@ -21,7 +21,7 @@ EOM fi -CONTENT=$($GCC -I $SRCDIR -E $SRCDIR/mlx/backend/common/compiled_preamble.h 2>/dev/null) +CONTENT=$($GCC -I "$SRCDIR" -E "$SRCDIR/mlx/backend/common/compiled_preamble.h" 2>/dev/null) cat << EOF > "$OUTPUT_FILE" const char* get_kernel_preamble() { diff --git a/mlx/backend/metal/make_compiled_preamble.sh b/mlx/backend/metal/make_compiled_preamble.sh index 40e3852bc..8e5d34b96 100644 --- a/mlx/backend/metal/make_compiled_preamble.sh +++ b/mlx/backend/metal/make_compiled_preamble.sh @@ -14,9 +14,9 @@ SRC_NAME=$(basename -- "${SRC_FILE}") INPUT_FILE=${SRC_DIR}/mlx/backend/metal/kernels/${SRC_FILE}.h OUTPUT_FILE=${OUTPUT_DIR}/${SRC_NAME}.cpp -mkdir -p $OUTPUT_DIR +mkdir -p "$OUTPUT_DIR" -CONTENT=$($CC -I $SRC_DIR -DMLX_METAL_JIT -E -P $INPUT_FILE $CFLAGS 2>/dev/null) +CONTENT=$($CC -I "$SRC_DIR" -DMLX_METAL_JIT -E -P "$INPUT_FILE" $CFLAGS 2>/dev/null) cat << EOF > "$OUTPUT_FILE" namespace mlx::core::metal {