From f55b6f1f2facf82f30378e9bf43d2c267749eb1b Mon Sep 17 00:00:00 2001 From: Cheng Date: Sun, 24 Aug 2025 15:33:08 +0900 Subject: [PATCH] Enable COMPILE_WARNING_AS_ERROR for linux builds in CI (#2534) --- .circleci/config.yml | 5 +++-- mlx/io/CMakeLists.txt | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 70f4e0fe5..502640d3e 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -89,7 +89,8 @@ jobs: command: | uv venv uv pip install cmake - uv pip install -e ".[dev]" -v + DEBUG=1 CMAKE_ARGS="-DCMAKE_COMPILE_WARNING_AS_ERROR=ON" \ + uv pip install -e ".[dev]" -v - run: name: Generate package stubs command: | @@ -231,7 +232,7 @@ jobs: name: Install Python package command: | uv venv - CMAKE_ARGS="-DMLX_BUILD_CUDA=ON -DCMAKE_CUDA_COMPILER=`which nvcc`" \ + DEBUG=1 CMAKE_ARGS="-DMLX_BUILD_CUDA=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON -DCMAKE_CUDA_COMPILER=`which nvcc`" \ uv pip install -e ".[dev]" -v - run: name: Run Python tests diff --git a/mlx/io/CMakeLists.txt b/mlx/io/CMakeLists.txt index f9ab1c44e..eebd7618b 100644 --- a/mlx/io/CMakeLists.txt +++ b/mlx/io/CMakeLists.txt @@ -11,7 +11,7 @@ if(MLX_BUILD_GGUF) FetchContent_Declare( gguflib GIT_REPOSITORY https://github.com/antirez/gguf-tools/ - GIT_TAG af7d88d808a7608a33723fba067036202910acb3) + GIT_TAG 8fa6eb65236618e28fd7710a0fba565f7faa1848) FetchContent_MakeAvailable(gguflib) target_include_directories(mlx PRIVATE $)