From f90206ad74f00046399727ef11f532c85b647af1 Mon Sep 17 00:00:00 2001
From: Awni Hannun <awni@apple.com>
Date: Wed, 19 Mar 2025 16:24:10 -0700
Subject: [PATCH] Guard nullptr dereference (#1972)

* guard nullptr dereference

* comment
---
 mlx/backend/metal/allocator.cpp    | 3 +++
 mlx/backend/no_metal/allocator.cpp | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/mlx/backend/metal/allocator.cpp b/mlx/backend/metal/allocator.cpp
index f2c95be20..8f5b28226 100644
--- a/mlx/backend/metal/allocator.cpp
+++ b/mlx/backend/metal/allocator.cpp
@@ -20,6 +20,9 @@ Allocator& allocator() {
 }
 
 void* Buffer::raw_ptr() {
+  if (!ptr_) {
+    return nullptr;
+  }
   return static_cast<MTL::Buffer*>(ptr_)->contents();
 }
 
diff --git a/mlx/backend/no_metal/allocator.cpp b/mlx/backend/no_metal/allocator.cpp
index 27e2ea06f..0429ea53a 100644
--- a/mlx/backend/no_metal/allocator.cpp
+++ b/mlx/backend/no_metal/allocator.cpp
@@ -10,6 +10,9 @@ Allocator& allocator() {
 }
 
 void* Buffer::raw_ptr() {
+  if (!ptr_) {
+    return nullptr;
+  }
   return static_cast<size_t*>(ptr_) + 1;
 }