zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-06-25 01:41:17 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix copy bug with many dims (#1137)

Browse Source
This commit is contained in:
Awni Hannun 2024-05-17 21:10:03 -07:00 committed by GitHub
parent 23406c9e9e
commit fb71a82ada
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mlx/backend/common/copy.cpp
View File

@ -256,7 +256,7 @@ void copy_general_general(
} }
int size = std::accumulate( int size = std::accumulate(
data_shape.begin() - 5, data_shape.end(), 1, std::multiplies<int>()); data_shape.end() - 5, data_shape.end(), 1, std::multiplies<int>());
for (int i = 0; i < src.size(); i += size) { for (int i = 0; i < src.size(); i += size) {
stride_t src_offset = i_offset + elem_to_loc(i, data_shape, i_strides); stride_t src_offset = i_offset + elem_to_loc(i, data_shape, i_strides);
stride_t dst_offset = o_offset + elem_to_loc(i, dst.shape(), o_strides); stride_t dst_offset = o_offset + elem_to_loc(i, dst.shape(), o_strides);

4
python/tests/test_array.py
View File

@ -1270,6 +1270,10 @@ class TestArray(mlx_tests.MLXTestCase):
x[:, 0] = 1.0 x[:, 0] = 1.0
self.assertTrue(mx.array_equal(x[:, 0], mx.ones((2, 4, 5, 3)))) self.assertTrue(mx.array_equal(x[:, 0], mx.ones((2, 4, 5, 3))))
x = mx.zeros((2, 2, 2, 2, 2, 2))
x[0, 0] = 1
self.assertTrue(mx.array_equal(x[0, 0], mx.ones((2, 2, 2, 2))))
def test_array_at(self): def test_array_at(self):
a = mx.array(1) a = mx.array(1)
a = a.at[None].add(1) a = a.at[None].add(1)