zhangyiss/mlx
1
0
Fork 0
mirror of https://github.com/ml-explore/mlx.git synced 2025-12-16 01:49:05 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
1,531 Commits 20 Branches 75 Tags
704f81c03d0b8d8b29fc4bd51f6347a6dbdf8e67
Commit Graph

61 Commits

Author SHA1 Message Date
Awni Hannun
df58b4133a [CUDA] Reduce use of managed memory (#2725)
Some checks failed
Nightly Build / build_linux_release (3.10) (push) Has been cancelled
Details
Nightly Build / build_linux_release (3.14) (push) Has been cancelled
Details
Nightly Build / build_linux_with_tests (3.10) (push) Has been cancelled
Details
Nightly Build / build_linux_with_tests (3.11) (push) Has been cancelled
Details
Nightly Build / build_linux_with_tests (3.12) (push) Has been cancelled
Details
Nightly Build / build_linux_with_tests (3.13) (push) Has been cancelled
Details
Nightly Build / build_linux_with_tests (3.14) (push) Has been cancelled
Details
Nightly Build / build_mac_release (3.10) (push) Has been cancelled
Details
Nightly Build / build_mac_release (3.13) (push) Has been cancelled
Details
Nightly Build / build_cuda_with_tests (push) Has been cancelled
Details
Nightly Build / build_cuda_release (push) Has been cancelled
Details
Nightly Build / Linux Fedora CPP Build (aarch64) (push) Has been cancelled
Details
Nightly Build / Linux Fedora CPP Build (x86_64) (push) Has been cancelled
Details 
* Use async cuda malloc managed with cuda 13

* add pool threshold

* refactor for regular cuda malloc

* load eval gpu for cuda

* remove use of cuda pool, use cuda free async

* fix

* fix

* fix

* fix

* fix + comment
 2025-11-05 16:05:23 -08:00
Ronan Collobert
8f8af61a37 fix warnings showing up with -Wall (#2692) 2025-10-24 11:43:35 -07:00
Awni Hannun
4e504039f5 [Metal] Release metal events (#2412) 
* release metal events

* fix

* fix
 2025-07-23 19:53:42 -07:00
Cheng
d34f887abc Add Primitive::name and remove Primitive::print (#2365) 2025-07-14 14:06:35 -07:00
Angelos Katharopoulos
aede70e81d Perf regression fix (#2243) 2025-06-03 17:55:12 -07:00
Cheng
95b7551d65 Do not check event.is_signaled() in eval_impl (#2230) 2025-06-02 13:23:34 -07:00
Awni Hannun
f1606486d2 Generalize gpu backend (#2138) 
* generalize gpu backend

* fix no_gpu build

* fix no_gpu build

* generalize gpu backend
 2025-04-30 09:08:17 -07:00
hdeng-apple
86984cad68 Remove static initializers (#2059) 
* Remove static initializers in device.cpp, load.cpp, pocketfft.h

* Remove static initializer InTracing::trace_stack

* Remove static initializer of CompilerCache cache

* Revert changes in pocketfft.h

* Remove duplicate private section of thread_pool()
 2025-04-24 06:14:49 -07:00
Awni Hannun
e5d35aa187 no sdpa in grad (#2054) 2025-04-08 19:13:54 -07:00
Awni Hannun
4e1994e9d7 move memory APIs into top level mlx.core (#1982) 2025-03-21 07:25:12 -07:00
Awni Hannun
7b7e2352cd fix malloc or wait deadlock (#1976) 2025-03-20 16:48:43 -07:00
Awni Hannun
3c164fca8c Fix multistream GPU deadlock (#1969) 
* fix multistream GPU deadlock

* comments
 2025-03-20 07:19:47 -07:00
Awni Hannun
c4230747a1 redesign for faster cpu/gpu synch (#1869) 
* redesign for faster cpu/gpu synch

* load + more async CPU

* use command encoder API and move more ops to use it

* make fence back-end generic + CPU only fence

* faster build

* fix async eval

* fixes + handle temporaries

* fix / improve cpu conv

* remove unused status, fix siblings

* fix extensions

* fix

* fix no cpu build

* format

* comments

* fix perf regression, remove unecessary abort

* fix events, task limit cpu

* fix waiting

* fix donation / temporaries in normalization
 2025-03-06 19:23:38 -08:00
Awni Hannun
a8666a757a fix shapeless compile on ubuntu24 (#1775) 2025-01-18 06:04:36 -08:00
Awni Hannun
33421c1dd3 Limit grad recursion depth by not recursing through non-grad inputs (#1764) 
* limit grad recursion depth

* add grad of module test
 2025-01-14 14:33:18 -08:00
Awni Hannun
1ccaf80575 Dynamic broadcasting for shapeless compile/export (#1722) 
* working towards dynamic broadcast

* shapeless broadcast

* fix build + nits

* use broadcast arrays in quantize matmul

* some cleanup / consistency

* mend

* some comments

* add vjp, jvp for broadcast axes
 2025-01-09 11:04:24 -08:00
Cheng
b8f76f717a Print exceptions in eval_cpu/eval_gpu and abort (#1754) 2025-01-08 06:31:09 -08:00
Awni Hannun
5548fcc96d fix synch race (#1719) 2024-12-18 12:25:16 -08:00
Awni Hannun
40c62c1321 Use int64 stride everywhere (#1671) 
* use int64 stride everywhere

* fix ext

* fix ext

* more shape + cleanup

* one more

* few more
 2024-12-09 11:09:02 -08:00
Awni Hannun
c1fe1ef081 Bfs width limit (#1568) 
* width limit

* fix

* large limit

* put env vars in env namespace
 2024-11-08 15:00:46 -08:00
Alex Barron
048fabdabd Fix vmap constant output size (#1524) 
* use inputs to determine output size

* remove noop vmap tests
 2024-10-30 16:16:53 -07:00
Awni Hannun
8e88e30d95 BFS graph evaluation order (#1525) 
* bfs order

* try fix event issue
 2024-10-25 10:27:19 -07:00
Awni Hannun
3274c6a087 Fix array is_available race cases (#1468) 2024-10-07 19:13:50 -07:00
Angelos Katharopoulos
e64349bbdd Make eval just wait if all arrays are scheduled (#1368) 2024-08-27 17:01:22 -07:00
nicolov
8c9f0278b9 Add vmap to scatter (#1200) 
* Add vmap to scatter

* updates

* vmap updates + a few more tests

* bug fix

---------

Co-authored-by: Awni Hannun <awni@apple.com>
 2024-08-05 20:12:27 -07:00
Awni Hannun
1fba87b0df Fix leak with multi-output primitives (#1274) 
* fix leak with multi-output primitives

* hopefully an actual fix
 2024-07-23 06:34:18 -07:00
Angelos Katharopoulos
5c1fa64fb0 Custom transforms (#1246) 2024-07-10 18:00:01 -07:00
Fangjun Kuang
f20e97b092 minor fixes (#1194) 
* minor fixes

* fix build errors
 2024-06-12 22:06:49 -07:00
Awni Hannun
e7a2a3dcd1 Fix a couple bugs (#1161) 
* fix jit reduce for RMS norm

* make strides a single buffer

* better eval error message

* fix compiling with inf and bf16

* fix cpu compile with bf16
 2024-05-28 15:18:18 -07:00
Awni Hannun
a9f80d60f6 improve error messaging in eval (#1101) 2024-05-10 10:04:07 -07:00
Awni Hannun
7f7b9662ea Fix leak for multi-output primitives which are never detached (#1059) 
* fix multi output leak

* ignore arrays that will be detached

* add some comments

* stray print
 2024-05-01 07:31:45 -07:00
Nripesh Niketan
a30e7ed2da feat: metal formatting and pre-commit bump (#1038) 
* feat: metal formatting and pre-commit bump

* add guards

* update

* more guards

* more guards

* smakk fix

* Refactor instantiation of ternary types in ternary.metal

* fix scan.metal
 2024-04-30 07:18:09 -07:00
Awni Hannun
8a0677d56d Shared events for synchronization + async eval (#998) 
* more async eval

* fix rebase

* try correct async eval

* fix async

* more tests for async eval

* use shared events for synchronization

* comment + cleanup

* with autorelease pool

* fix no metal build

* fix compile

* fix patch

* don't eval if asyn evale'd

* don't use is_evaled

* comments

* more multi stream tests

* try and cleanup use of is_evaled

* use a status flag
 2024-04-17 06:16:02 -07:00
Nripesh Niketan
ffff671273 Update pre-commit hooks (#984) 2024-04-11 07:27:53 -07:00
Awni Hannun
8580d997ff Try a stack-based DFS for eval (#980) 
* rebase

* nit

* fix eval in vmap
 2024-04-10 17:05:13 -07:00
Awni Hannun
99abb9eff4 Async eval (#972) 2024-04-09 18:34:00 -07:00
Awni Hannun
aac2f9fb61 Improve profiling with gpu tracing (#969) 
* improve profiling with gpu tracing

* fix for linux

* nit

* doc fix

* fix example
 2024-04-07 21:47:43 -07:00
Jack Mousseau
45f636e759 Add Metal debug option and capture functions (#707) 
* Add Metal debug option and capture functions

* Add brief Metal debugger documentation

* doc nits

---------

Co-authored-by: Awni Hannun <awni@apple.com>
 2024-03-28 09:40:31 -07:00
Cheng
90dfa43ff1 Don't use make_unique to create shared_ptr (#902) 
The code compiled because shared_ptr's constructor actually accepts
unique_ptr.
 2024-03-27 06:13:29 -07:00
Awni Hannun
dc175f08d3 Fix race in multi-stream eval (#911) 
* maybe fix race

* comment
 2024-03-26 16:36:36 -07:00
Cheng
f0ae00da12 Reduce implicit copies in make_array (#874) 
1. Move shapes into outputs instead of copying them.
2. Pass primitive by const ref as it is always copied into outputs, which
   removes a copy when calling make_array.
 2024-03-22 06:29:16 -07:00
nicolov
105d236889 Add vmap for SVD and inverse (#849) 2024-03-21 13:18:27 -07:00
Cheng
4650d94d98 Add missing && in eval (#864) 
Without the && args would be copied and perfect forwarding won't work.

To avoid eval calling itself recursively, the vector version of eval is
changed to take by value instead, which will save a copy of array when a
rvalue is passed.
 2024-03-21 06:15:48 -07:00
Cheng
d39ed54f8e Some C++ code are not needed (#841) 
1. Anonymous namespace means internal linkage, static keyword is not needed.
2. The default constructor of std::shared_ptr initializes the pointer to
   nullptr, you don't need to explicitly set it.
 2024-03-18 17:04:10 -07:00
Angelos Katharopoulos
76c919b4ec NumberOfElements for shapeless compile and vmap fixes (#802) 2024-03-13 10:34:14 -07:00
Awni Hannun
a4d290adb9 Remove depth traversal (#813) 
* no depth traversal

* counter outside loop
 2024-03-09 20:21:32 -08:00
Awni Hannun
1074674e32 Add a maximum graph depth (#797) 
* add a maximum graph depth

* remember how to use C++
 2024-03-06 15:39:00 -08:00
Awni Hannun
e88e474fd1 Reduce vmap + some fixes (#601) 2024-02-01 11:30:28 -08:00
Angelos Katharopoulos
0de5988f92 Custom VJP and checkpointing (#541) 
* Implement custom_vjp and checkpointing
* Add a dependency management primitive
* Change the eval order to deep branches first
* Add graph depth tracking to the array
 2024-01-30 16:04:45 -08:00
Awni Hannun
8993382aaa Buffer Donation (#519) 
* buffer donation

* fix to move shared pointer

* format

* gpu in place for copy and binary

* revert ops test

* cpu in place

* a little cleanup

* remove useless bench
 2024-01-26 16:30:33 -08:00