zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clingo: don't skip tests that deal with file permissions

Browse Source 
When we first merged the ASP-based solver, unit-tests
were run in a Docker container with root permissions
and that was preventing a few tests to succeed.

Since some time though, clingo is tested as a regular
user within Github Actions VMs, so we should start to
run checks again.
This commit is contained in:
Massimiliano Culpo
2021-05-08 09:11:27 +02:00
committed by Todd Gamblin
parent daebf5caf8
commit 00a1418d10
3 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/spack/spack/test/cmd/buildcache.py
View File

@@ -125,10 +125,6 @@ def test_buildcache_create_fails_on_noargs(tmpdir):
buildcache('create', '-d', str(tmpdir), '--unsigned') buildcache('create', '-d', str(tmpdir), '--unsigned')
@pytest.mark.skipif(
os.environ.get('SPACK_TEST_SOLVER') == 'clingo',
reason='Test for Clingo are run in a container with root permissions'
)
def test_buildcache_create_fail_on_perm_denied( def test_buildcache_create_fail_on_perm_denied(
install_mockery, mock_fetch, monkeypatch, tmpdir): install_mockery, mock_fetch, monkeypatch, tmpdir):
"""Ensure that buildcache create fails on permission denied error.""" """Ensure that buildcache create fails on permission denied error."""

8
lib/spack/spack/test/database.py
View File

@@ -638,10 +638,6 @@ def test_090_non_root_ref_counts(mutable_database):
assert mpich_rec.ref_count == 0 assert mpich_rec.ref_count == 0
@pytest.mark.skipif(
os.environ.get('SPACK_TEST_SOLVER') == 'clingo',
reason='Test for Clingo are run in a container with root permissions'
)
def test_100_no_write_with_exception_on_remove(database): def test_100_no_write_with_exception_on_remove(database):
def fail_while_writing(): def fail_while_writing():
with database.write_transaction(): with database.write_transaction():
@@ -659,10 +655,6 @@ def fail_while_writing():
assert len(database.query('mpileaks ^zmpi', installed=any)) == 1 assert len(database.query('mpileaks ^zmpi', installed=any)) == 1
@pytest.mark.skipif(
os.environ.get('SPACK_TEST_SOLVER') == 'clingo',
reason='Test for Clingo are run in a container with root permissions'
)
def test_110_no_write_with_exception_on_install(database): def test_110_no_write_with_exception_on_install(database):
def fail_while_writing(): def fail_while_writing():
with database.write_transaction(): with database.write_transaction():

4
lib/spack/spack/test/llnl/util/lock.py
View File

@@ -661,10 +661,6 @@ def test_upgrade_read_to_write(private_lock_path):
assert lock._file is None assert lock._file is None
@pytest.mark.skipif(
os.environ.get('SPACK_TEST_SOLVER') == 'clingo',
reason='Test for Clingo are run in a container with root permissions'
)
def test_upgrade_read_to_write_fails_with_readonly_file(private_lock_path): def test_upgrade_read_to_write_fails_with_readonly_file(private_lock_path):
"""Test that read-only file can be read-locked but not write-locked.""" """Test that read-only file can be read-locked but not write-locked."""
# ensure lock file exists the first time # ensure lock file exists the first time